Skip to content

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Jun 8, 2020

Stack from ghstack:

Summary:

Adding a couple of docstrings to _jit_pass_dedup_module_uses and
_jit_pass_insert_observers.

Test Plan:

CI, no logic change

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D21975880

Summary:

Adding a couple of docstrings to `_jit_pass_dedup_module_uses` and
`_jit_pass_insert_observers`.

Test Plan:

CI, no logic change

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@vkuzo vkuzo requested a review from apaszke as a code owner June 8, 2020 22:55
vkuzo added a commit that referenced this pull request Jun 8, 2020
Summary:

Adding a couple of docstrings to `_jit_pass_dedup_module_uses` and
`_jit_pass_insert_observers`.

Test Plan:

CI, no logic change

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 1dd48ef
Pull Request resolved: #39683
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 8, 2020
Summary:

Adding a couple of docstrings to `_jit_pass_dedup_module_uses` and
`_jit_pass_insert_observers`.

Test Plan:

CI, no logic change

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Jun 9, 2020
Summary:

Adding a couple of docstrings to `_jit_pass_dedup_module_uses` and
`_jit_pass_insert_observers`.

Test Plan:

CI, no logic change

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 821c1b4
Pull Request resolved: #39683
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG Thanks!

Summary:

Adding a couple of docstrings to `_jit_pass_dedup_module_uses` and
`_jit_pass_insert_observers`.

Test Plan:

CI, no logic change

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21975880](https://our.internmc.facebook.com/intern/diff/D21975880)

[ghstack-poisoned]
@dr-ci
Copy link

dr-ci bot commented Jun 11, 2020

💊 CI failures summary and remediations

As of commit e17393c (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in f8561ac.

@facebook-github-bot facebook-github-bot deleted the gh/vkuzo/82/head branch June 14, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants