-
Notifications
You must be signed in to change notification settings - Fork 25.6k
graph mode: add docs to pre-calibration passes #39683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adding a couple of docstrings to `_jit_pass_dedup_module_uses` and `_jit_pass_insert_observers`. Test Plan: CI, no logic change Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
reviewed
Jun 8, 2020
jerryzh168
reviewed
Jun 8, 2020
Summary: Adding a couple of docstrings to `_jit_pass_dedup_module_uses` and `_jit_pass_insert_observers`. Test Plan: CI, no logic change Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG Thanks!
This was referenced Jun 9, 2020
Summary: Adding a couple of docstrings to `_jit_pass_dedup_module_uses` and `_jit_pass_insert_observers`. Test Plan: CI, no logic change Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21975880](https://our.internmc.facebook.com/intern/diff/D21975880) [ghstack-poisoned]
This was referenced Jun 10, 2020
💊 CI failures summary and remediationsAs of commit e17393c (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
This pull request has been merged in f8561ac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
_forward
of per channel observers scriptable #39840 qat graph mode: make per channel observers scriptableSummary:
Adding a couple of docstrings to
_jit_pass_dedup_module_uses
and_jit_pass_insert_observers
.Test Plan:
CI, no logic change
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21975880