[TensorExpr] Fast sigmoid for LLVM #39717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
ZolotukhinM
suggested changes
Jun 9, 2020
| } | ||
| // TODO: fast exp | ||
| // TODO: fast erf | ||
| // TODO: fast sigmoid |
There was a problem hiding this comment.
Nit: remove the finished "TODO" please.
| const std::vector<CodeGen::BufferArg>& params, | ||
| at::Device device = at::kCPU); | ||
|
|
||
| class TORCH_API GenericIntrinsicsExpander : public IRMutator { |
There was a problem hiding this comment.
Nit: we're creating an entire class (+ derived from it) just to redefine a single function. We could've get away with just a single free-standing function here.
There was a problem hiding this comment.
This class and function is invoked implicity through accept_mutator. Unless we come up with more magic wrappers here, there is no easy way to call into this in our current infrastructure with a free standing function.
Differential Revision: [D21949849](https://our.internmc.facebook.com/intern/diff/D21949849) [ghstack-poisoned]
ZolotukhinM
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D21949849