Skip to content

Remove thrust casting from static_cast_with_inter_type #39905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Remove thrust casting from static_cast_with_inter_type #39905

wants to merge 3 commits into from

Conversation

zasdfgbnm
Copy link
Collaborator

No description provided.

@zasdfgbnm zasdfgbnm added the module: complex Related to complex number support in PyTorch label Jun 12, 2020
@zasdfgbnm zasdfgbnm mentioned this pull request Jun 12, 2020
Closed
@dr-ci
Copy link

dr-ci bot commented Jun 12, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit fbbf833 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

1 failure not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_xenial_rocm3_3_py3_6_test Set Up CI Environment After attach_workspace 🔁 rerun

Extra GitHub checks: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 18 times.

@zasdfgbnm
Copy link
Collaborator Author

CUDA 9.2 bug is still there, needs to wait until all thrust::complex removed from kernels

@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 23, 2020
@zou3519
Copy link
Contributor

zou3519 commented Jun 23, 2020

@zasdfgbnm when this is ready feel free to tag someone as a reviewer (or ping me and I'll try to review or find someone who can).

@zasdfgbnm zasdfgbnm requested a review from ngimel June 23, 2020 20:28
@zasdfgbnm
Copy link
Collaborator Author

@zou3519 Just rebased, and I believe this should be ready. I have tagged @ngimel has a reviewer she recently reviewed similar changes.

@zasdfgbnm
Copy link
Collaborator Author

ping @ngimel

ngimel
ngimel approved these changes Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@ngimel ngimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on CI

facebook-github-bot
facebook-github-bot reviewed Jul 13, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zasdfgbnm zasdfgbnm deleted the ci-all/remove-thrust-typecast branch July 14, 2020 02:28
@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in 34e11b4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

Merged module: complex Related to complex number support in PyTorch open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zasdfgbnm @zou3519 @facebook-github-bot @ngimel @pytorchbot @mruberry