Skip to content

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Jun 12, 2020

Stack from ghstack:

Summary:
propagateQuantizationOps generate new dequantize ops, so this pass should run after that.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D22014712

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@dr-ci
Copy link

dr-ci bot commented Jun 12, 2020

💊 CI failures summary and remediations

As of commit b17af0e (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_bazel_test (1/1)

Step: "Set Up CI Environment After attach_workspace" (full log | diagnosis details | 🔁 rerun) ❄️

gpg: no valid OpenPGP data found.
+ curl -s -L --retry 3 https://nvidia.github.io/nvidia-docker/gpgkey 
+ sudo apt-key add - 
gpg: no valid OpenPGP data found. 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 10 times.

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22014712](https://our.internmc.facebook.com/intern/diff/D22014712)

[ghstack-poisoned]
Copy link
Contributor

@vkuzo vkuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, would be awesome if we also had some context on the "why" (for new team members to learn)

@jerryzh168
Copy link
Contributor Author

lg, would be awesome if we also had some context on the "why" (for new team members to learn)

sure, updated summary

Summary:
`propagateQuantizationOps` generate new `dequantize` ops, so this pass should run after that.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22014712](https://our.internmc.facebook.com/intern/diff/D22014712)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b372000.

xwang233 pushed a commit to xwang233/pytorch that referenced this pull request Jun 20, 2020
…39923)

Summary: Pull Request resolved: pytorch#39923

Test Plan: Imported from OSS

Differential Revision: D22014712

fbshipit-source-id: a681bbab5d90ac8ebeff03cde5277501e86ee1d4
@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/349/head branch June 20, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants