Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Jun 12, 2020

It's pointless to continue if conda install, Visual Studio or pip install commands have failed

It's pointless to continue if `conda install`, Visual Studio or `pip install` commands have failed
@malfet malfet requested review from albanD and ezyang June 12, 2020 17:54
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dr-ci
Copy link

dr-ci bot commented Jun 12, 2020

💊 CI failures summary and remediations

As of commit db0fe42 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

1 failure confirmed as flaky and can be ignored:

  • pytorch_linux_bionic_py3_8_gcc9_test

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in 8749aac.

@malfet malfet deleted the malfet/win-error-on-pip-failures branch June 18, 2020 21:13
xwang233 pushed a commit to xwang233/pytorch that referenced this pull request Jun 20, 2020
Summary:
It's pointless to continue if `conda install`, Visual Studio or `pip install` commands have failed
Pull Request resolved: pytorch#39951

Differential Revision: D22026240

Pulled By: malfet

fbshipit-source-id: de982e9d328e3fd7d9f0bd14400c0116b3010281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants