[quant][graphmode] Rename graph mode quantization API from *_script to *_jit
#40212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jun 18, 2020
…quantize_jit`" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 07ad074 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 13 times. |
…quantize_jit`" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
… `*_script` to `*_jit`" Summary: based on discussions in #40198 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22144745](https://our.internmc.facebook.com/intern/diff/D22144745) [ghstack-poisoned]
jerryzh168
changed the title
quantize_jit*_script to *_jit
z-a-f
approved these changes
Jun 19, 2020
Comment on lines
31
to
36
| script_qconfig, | ||
| prepare_jit, | ||
| convert_jit, | ||
| prepare_dynamic_jit, | ||
| convert_dynamic_jit, | ||
| fuse_conv_bn_jit, |
There was a problem hiding this comment.
nit: Can you put them in alphabetical order -- easier to find. Also, in my personal opinion having separate lines for import (instead of ()) looks better :)
There was a problem hiding this comment.
Sure, will put them in alphabetical order, () has less things to type I think?
… `*_script` to `*_jit`" Summary: based on discussions in #40198 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22144745](https://our.internmc.facebook.com/intern/diff/D22144745) [ghstack-poisoned]
|
This pull request has been merged in b2f489d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
*_scriptto*_jit#40212 [quant][graphmode] Rename graph mode quantization API from*_scriptto*_jitSummary:
based on discussions in #40198
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D22144745