graph mode: add hardswish inplace handling #40284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: WIP Test Plan: ``` python test/test_quantization.py TestQuantizeScriptPTSQOps.test_hardswish ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jun 19, 2020
facebook-github-bot
added
the
oncall: jit
vkuzo
changed the title
💊 CI failures summary and remediationsAs of commit 0f5fed7 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 30 times. |
Summary: WIP need to fix inplace before landing. graph comparison: https://www.internalfb.com/intern/paste/P133715227/ Test Plan: ``` python test/test_quantization.py TestQuantizeScriptPTSQOps.test_hardswish ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
reviewed
Jun 19, 2020
| else: | ||
| # module under test can contain in-place ops, and we depend on | ||
| # input data staying constant for comparisons | ||
| data_copy = copy.deepcopy(data) |
There was a problem hiding this comment.
makes sense, wonder why we didn't discover this in other tests
There was a problem hiding this comment.
oh, maybe this is the first one modifying input data
jerryzh168
reviewed
Jun 19, 2020
Comment on lines
2096
to
2097
| for tracing in [True, False]: | ||
| m = self.checkGraphModeOp(hardswish, data, "quantized::hardswish", tracing) | ||
| FileCheck().check_not("aten::hardswish") \ | ||
| .run(m.graph) | ||
| for m in modules: |
There was a problem hiding this comment.
nit: you can use itertools to reduce identation, see other test cases in the file
Summary: Adds graph mode handling for inplace hardswish, and test coverage for functional hardswish. Test Plan: ``` python test/test_quantization.py TestQuantizeScriptPTSQOps.test_hardswish ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22140628](https://our.internmc.facebook.com/intern/diff/D22140628) [ghstack-poisoned]
Summary: Adds graph mode handling for inplace hardswish, and test coverage for functional hardswish. Test Plan: ``` python test/test_quantization.py TestQuantizeScriptPTSQOps.test_hardswish ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22140628](https://our.internmc.facebook.com/intern/diff/D22140628) [ghstack-poisoned]
Summary: Adds graph mode handling for inplace hardswish, and test coverage for functional hardswish. Test Plan: ``` python test/test_quantization.py TestQuantizeScriptPTSQOps.test_hardswish ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22140628](https://our.internmc.facebook.com/intern/diff/D22140628) [ghstack-poisoned]
Summary: Adds graph mode handling for inplace hardswish, and test coverage for functional hardswish. Test Plan: ``` python test/test_quantization.py TestQuantizeScriptPTSQOps.test_hardswish ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22140628](https://our.internmc.facebook.com/intern/diff/D22140628) [ghstack-poisoned]
|
This pull request has been merged in ab8a99b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Adds graph mode handling for inplace hardswish, and test coverage for functional hardswish.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D22140628