Skip to content

[JIT] Remove dead store in quantization_patterns.h #40623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[JIT] Remove dead store in quantization_patterns.h #40623

wants to merge 1 commit into from

Conversation

SplitInfinity
Copy link

Test Plan: Continuous integration.

Differential Revision: D22259209

@SplitInfinity SplitInfinity requested a review from apaszke as a code owner June 26, 2020 16:57
@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue fb-exported labels Jun 26, 2020
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22259209

@dr-ci
Copy link

dr-ci bot commented Jun 26, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit a3d9108 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 8 times.

@SplitInfinity SplitInfinity requested review from jerryzh168 and removed request for jerryzh168 June 26, 2020 17:10
jerryzh168
jerryzh168 reviewed Jun 26, 2020
View reviewed changes
torch/csrc/jit/passes/quantization/quantization_patterns.h Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this used in the next line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested review before checking tests and then immediately unrequested, sorry about that. Let me figure out what's going on. This dead store was flagged by an internal tool.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's related to const auto&, you can try changing to auto

@SplitInfinity
Copy link
Author

I requested review before checking tests and then immediately unrequested, sorry about that. Let me figure out what's going on. This dead store was flagged by an internal tool.

@facebook-github-bot
[JIT] Remove dead store in quantization_patterns.h (pytorch#40623)
a3d9108 
Summary: Pull Request resolved: pytorch#40623

Test Plan: Continuous integration.

Differential Revision: D22259209

fbshipit-source-id: 2cf7869a9bd7a8560acf0aeca8f487597e112c09
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22259209

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22259209

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22259209

@SplitInfinity SplitInfinity requested a review from jerryzh168 June 26, 2020 18:31
jerryzh168
jerryzh168 approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks!

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 0a19534.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

fb-exported Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SplitInfinity @facebook-github-bot @jerryzh168 @mruberry