Upgrade cpp docs Sphinx/breathe/exhale to latest version #41312
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was hoping that exhale had gotten incremental recompilation in its latest version, but experimentally this does not seem to have been the case. Still, I had gotten the whole shebang to be working on the latest version of these packages, so might as well land the upgrade. There was one bug in Optional.h that I had to fix; see the cited bug report. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Jul 11, 2020
I was hoping that exhale had gotten incremental recompilation in its latest version, but experimentally this does not seem to have been the case. Still, I had gotten the whole shebang to be working on the latest version of these packages, so might as well land the upgrade. There was one bug in Optional.h that I had to fix; see the cited bug report. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 217d026 Pull Request resolved: #41312
💊 CI failures summary and remediationsAs of commit 423997b (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 18 times. |
I was hoping that exhale had gotten incremental recompilation in its latest version, but experimentally this does not seem to have been the case. Still, I had gotten the whole shebang to be working on the latest version of these packages, so might as well land the upgrade. There was one bug in Optional.h that I had to fix; see the cited bug report. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
I was hoping that exhale had gotten incremental recompilation in its latest version, but experimentally this does not seem to have been the case. Still, I had gotten the whole shebang to be working on the latest version of these packages, so might as well land the upgrade. There was one bug in Optional.h that I had to fix; see the cited bug report. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
I was hoping that exhale had gotten incremental recompilation in its latest version, but experimentally this does not seem to have been the case. Still, I had gotten the whole shebang to be working on the latest version of these packages, so might as well land the upgrade. There was one bug in Optional.h that I had to fix; see the cited bug report. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Jul 13, 2020
I was hoping that exhale had gotten incremental recompilation in its latest version, but experimentally this does not seem to have been the case. Still, I had gotten the whole shebang to be working on the latest version of these packages, so might as well land the upgrade. There was one bug in Optional.h that I had to fix; see the cited bug report. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 14b087a Pull Request resolved: #41312
I was hoping that exhale had gotten incremental recompilation in its latest version, but experimentally this does not seem to have been the case. Still, I had gotten the whole shebang to be working on the latest version of these packages, so might as well land the upgrade. There was one bug in Optional.h that I had to fix; see the cited bug report. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Jul 13, 2020
I was hoping that exhale had gotten incremental recompilation in its latest version, but experimentally this does not seem to have been the case. Still, I had gotten the whole shebang to be working on the latest version of these packages, so might as well land the upgrade. There was one bug in Optional.h that I had to fix; see the cited bug report. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 0566182 Pull Request resolved: #41312
zou3519
approved these changes
Jul 14, 2020
albanD
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
I was hoping that exhale had gotten incremental recompilation
in its latest version, but experimentally this does not seem
to have been the case. Still, I had gotten the whole shebang
to be working on the latest version of these packages, so might
as well land the upgrade. There was one bug in Optional.h that
I had to fix; see the cited bug report.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D22526349