[RPC tests] Fix test_init_(rpc|pg)_then_(rpc|pg) not shutting down RPC #41558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses this bug report: #41474 The problem was due to non-deterministic destruction order of two global static variables: the mutexes used by glog and the RPC agent (which was still set because we didn't call `rpc.shutdown()`). When the TensorPipe RPC agent shuts down some callbacks may fire with an error and thus attempt to log something. If the mutexes have already been destroyed this causes a SIGABRT. Differential Revision: [D22582779](https://our.internmc.facebook.com/intern/diff/D22582779/) [ghstack-poisoned]
lw
requested review from
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
…ing down RPC" The problem was due to non-deterministic destruction order of two global static variables: the mutexes used by glog and the RPC agent (which was still set because we didn't call `rpc.shutdown()`). When the TensorPipe RPC agent shuts down some callbacks may fire with an error and thus attempt to log something. If the mutexes have already been destroyed this causes a SIGABRT. Fixes #41474 Differential Revision: [D22582779](https://our.internmc.facebook.com/intern/diff/D22582779/) Differential Revision: [D22582779](https://our.internmc.facebook.com/intern/diff/D22582779) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 411dffd (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 14 times. |
|
Do we also need to add the shutdown call to other tests, e.g., |
…ing down RPC" The problem was due to non-deterministic destruction order of two global static variables: the mutexes used by glog and the RPC agent (which was still set because we didn't call `rpc.shutdown()`). When the TensorPipe RPC agent shuts down some callbacks may fire with an error and thus attempt to log something. If the mutexes have already been destroyed this causes a SIGABRT. Fixes #41474 Differential Revision: [D22582779](https://our.internmc.facebook.com/intern/diff/D22582779/) Differential Revision: [D22582779](https://our.internmc.facebook.com/intern/diff/D22582779) [ghstack-poisoned]
lw
added a commit
that referenced
this pull request
Jul 16, 2020
Pull Request resolved: #41558 The problem was due to non-deterministic destruction order of two global static variables: the mutexes used by glog and the RPC agent (which was still set because we didn't call `rpc.shutdown()`). When the TensorPipe RPC agent shuts down some callbacks may fire with an error and thus attempt to log something. If the mutexes have already been destroyed this causes a SIGABRT. Fixes #41474 ghstack-source-id: 107947863 Differential Revision: [D22582779](https://our.internmc.facebook.com/intern/diff/D22582779/)
|
Added it to |
…ing down RPC" The problem was due to non-deterministic destruction order of two global static variables: the mutexes used by glog and the RPC agent (which was still set because we didn't call `rpc.shutdown()`). When the TensorPipe RPC agent shuts down some callbacks may fire with an error and thus attempt to log something. If the mutexes have already been destroyed this causes a SIGABRT. Fixes #41474 Differential Revision: [D22582779](https://our.internmc.facebook.com/intern/diff/D22582779/) Differential Revision: [D22582779](https://our.internmc.facebook.com/intern/diff/D22582779) [ghstack-poisoned]
lw
added a commit
that referenced
this pull request
Jul 17, 2020
Pull Request resolved: #41558 The problem was due to non-deterministic destruction order of two global static variables: the mutexes used by glog and the RPC agent (which was still set because we didn't call `rpc.shutdown()`). When the TensorPipe RPC agent shuts down some callbacks may fire with an error and thus attempt to log something. If the mutexes have already been destroyed this causes a SIGABRT. Fixes #41474 ghstack-source-id: 107995887 Differential Revision: [D22582779](https://our.internmc.facebook.com/intern/diff/D22582779/)
|
Actually, |
…ing down RPC" The problem was due to non-deterministic destruction order of two global static variables: the mutexes used by glog and the RPC agent (which was still set because we didn't call `rpc.shutdown()`). When the TensorPipe RPC agent shuts down some callbacks may fire with an error and thus attempt to log something. If the mutexes have already been destroyed this causes a SIGABRT. Fixes #41474 Differential Revision: [D22582779](https://our.internmc.facebook.com/intern/diff/D22582779/) Differential Revision: [D22582779](https://our.internmc.facebook.com/intern/diff/D22582779) [ghstack-poisoned]
lw
added a commit
that referenced
this pull request
Jul 22, 2020
Pull Request resolved: #41558 The problem was due to non-deterministic destruction order of two global static variables: the mutexes used by glog and the RPC agent (which was still set because we didn't call `rpc.shutdown()`). When the TensorPipe RPC agent shuts down some callbacks may fire with an error and thus attempt to log something. If the mutexes have already been destroyed this causes a SIGABRT. Fixes #41474 ghstack-source-id: 108231453 Differential Revision: [D22582779](https://our.internmc.facebook.com/intern/diff/D22582779/)
|
This pull request has been merged in fced54a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The problem was due to non-deterministic destruction order of two global static variables: the mutexes used by glog and the RPC agent (which was still set because we didn't call
rpc.shutdown()). When the TensorPipe RPC agent shuts down some callbacks may fire with an error and thus attempt to log something. If the mutexes have already been destroyed this causes a SIGABRT.Fixes #41474
Differential Revision: D22582779
Differential Revision: D22582779