Skip to content

[Caffe2] Fix spatial_bn bug for computing running_var on CPU or on CUDA without CuDNN #42151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Caffe2] Fix spatial_bn bug for computing running_var on CPU or on CUDA without CuDNN #42151

wants to merge 1 commit into from

Conversation

xiaomengy
Copy link
Contributor

Summary: Previously our Caffe2 SpatialBN op impl was incorrect for computing running_var without unbias coefficent. Actually it should fail the test because the output will be different with CuDNN's output. However, our tests are too weak to find this bug. This diff fix all of them.

Test Plan: buck test mode/dev-nosan //caffe2/caffe2/python/operator_test:spatial_bn_op_test

Differential Revision: D22786127

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22786127

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22786127

@dr-ci
Copy link

dr-ci bot commented Jul 28, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 1d6dcd0 (more details on the Dr. CI page):

  • 1/2 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
  • 1/2 broken upstream at merge base 4c7fb8c on Jul 28 from 10:05am to 4:00pm PDT (14 commits; 73ff252 - e2344db)

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 16 times.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22786127

@xiaomengy @facebook-github-bot
[Caffe2] Fix spatial_bn bug for computing running_var on CPU or on CU…
1d6dcd0 
…DA without CuDNN (pytorch#42151)

Summary:
Pull Request resolved: pytorch#42151

Previously our Caffe2 SpatialBN op impl was incorrect for computing running_var without unbias coefficent. Actually it should fail the test because the output will be different with CuDNN's output. However, our tests are too weak to find this bug. This diff fix all of them.

Test Plan: buck test mode/dev-nosan //caffe2/caffe2/python/operator_test:spatial_bn_op_test

Differential Revision: D22786127

fbshipit-source-id: ca50e32d7381b017940eca5b48040ea26b5cfe74
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22786127

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 60f5154.

@xiaomengy xiaomengy deleted the export-D22786127 branch July 29, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houseroad houseroad houseroad approved these changes

Assignees

No one assigned

Labels

fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xiaomengy @facebook-github-bot @houseroad @mruberry