TearDown function for ProcessGroupNCCLTest Initializer #42209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a TearDown function to the testing superclass to ensure that the NCCL_BLOCKING_WAIT environment variable is reset after each test case. Differential Revision: [D22782672](https://our.internmc.facebook.com/intern/diff/D22782672/) [ghstack-poisoned]
osalpekar
requested review from
mrshenli,
pietern and
zhaojuanmao
as code owners
This was referenced Jul 29, 2020
💊 CI failures summary and remediationsAs of commit 0457f1f (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 18 times. |
mrshenli
approved these changes
Jul 29, 2020
This PR adds a TearDown function to the testing superclass to ensure that the NCCL_BLOCKING_WAIT environment variable is reset after each test case. Differential Revision: [D22782672](https://our.internmc.facebook.com/intern/diff/D22782672/) [ghstack-poisoned]
This PR adds a TearDown function to the testing superclass to ensure that the NCCL_BLOCKING_WAIT environment variable is reset after each test case. Differential Revision: [D22782672](https://our.internmc.facebook.com/intern/diff/D22782672/) [ghstack-poisoned]
This PR adds a TearDown function to the testing superclass to ensure that the NCCL_BLOCKING_WAIT environment variable is reset after each test case. Differential Revision: [D22782672](https://our.internmc.facebook.com/intern/diff/D22782672/) [ghstack-poisoned]
|
This pull request has been merged in 3ca3617. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR adds a TearDown function to the testing superclass to ensure that the NCCL_BLOCKING_WAIT environment variable is reset after each test case.
Differential Revision: D22782672