Make resize_ use normal device dispatch #42240
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit fa3c429 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 7 times. |
There was a problem hiding this comment.
@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resize_only requires manual registration toAutogradkey and its device kernels can safely live together with our normal device dispatch innative_functions.yaml.But currently we do manual registration for
CPU/CUDAkernels (and leaves no dispatch in native_functions.yaml) which makesresize_non-overrideable from backend point of view. While it indeed should dispatch at device level, this caused xla to whitelistresize_and register a lowering to XLA key. This PR moves the device dispatch ofresize_back tonative_functions.yamlso that it shows up asabstractmethod properly for downstream extensions.Note that we also do manual registration for
copy_/detach_/resize_as_/etcin aten but they are slightly different thanresize_since for them we only registercatchAllkernels instead of device kernels. I'll need to investigate and send a followup PR for those ops.