refactor torch/cuda/nccl.h to remove direct dependency on NCCL in libtorch_python

[walterddr]

No description provided.

[dr-ci]

💊 CI failures summary and remediations

As of commit fcf24c1 (more details on the Dr. CI page):

---

✅ None of the CI failures appear to be your fault 💚

---

• 1/1 broken upstream at merge base fa6b34b from Aug 17 until Aug 19 (43 commits; 768c2a8 - 1e248ca)

---

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

• binary_windows_libtorch_3_7_cpu_release_build from Aug 17 until Aug 19 (43 commits; 768c2a8 - 1e248ca)
  • 🔁 rerun

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 17 times.

[malfet]

Can you use enum class instead of C-style enums (and if aliases are not allowed in enum class defined them using using construct?

Suggested change

	typedef enum { ncclSuccess = 0,
	ncclUnhandledCudaError = 1,
	ncclSystemError = 2,
	ncclInternalError = 3,
	ncclInvalidArgument = 4,
	ncclInvalidUsage = 5,
	ncclNumResults = 6 } ncclResult_t;
	/* Reduction operation selector */
	typedef enum { ncclSum = 0,
	ncclProd = 1,
	ncclMax = 2,
	ncclMin = 3,
	ncclNumOps = 4 } ncclRedOp_t;
	/* Data types */
	typedef enum { ncclInt8 = 0, ncclChar = 0,
	ncclUint8 = 1,
	ncclInt32 = 2, ncclInt = 2,
	ncclUint32 = 3,
	ncclInt64 = 4,
	ncclUint64 = 5,
	ncclFloat16 = 6, ncclHalf = 6,
	ncclFloat32 = 7, ncclFloat = 7,
	ncclFloat64 = 8, ncclDouble = 8,
	ncclNumTypes = 9 } ncclDataType_t;
	enum class ncclResult {
	Success = 0,
	UnhandledCudaError = 1,
	SystemError = 2,
	InternalError = 3,
	InvalidArgument = 4,
	InvalidUsage = 5,
	NumResults = 6,
	};
	/* Reduction operation selector */
	enum class ncclRedOpt_t { Sum = 0,
	Prod = 1,
	Max = 2,
	Min = 3,
	NumOps = 4 };
	/* Data types */
	enum class ncclDataType {
	Int8 = 0,
	Char = 0,
	Uint8 = 1,
	Int32 = 2,
	Uint32 = 3,
	Int64 = 4,
	Uint64 = 5,
	Float16 = 6
	Float32 = 7
	Float64 = 8,
	ncclNumTypes = 9
	};
	using , ncclDouble = ncclDataType:Float64;

[walterddr]

thanks for the review @malfet. there were some issues during build time after I rebase, I will try to fix them asap.

[facebook-github-bot]

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@walterddr merged this pull request in 3eb3132.