Skip to content

Conversation

ZolotukhinM
Copy link

@ZolotukhinM ZolotukhinM commented Aug 6, 2020

Stack from ghstack:

Both the profiling executor and the legacy executor have the debug
loggin now.

Ideally, if we had a pass manager, this could be done as a part of it,
but since we have none, I had to insert the debug statements manually.

Differential Revision: D22981675

Both the profiling executor and the legacy executor have the debug
loggin now.

Ideally, if we had a pass manager, this could be done as a part of it,
but since we have none, I had to insert the debug statements manually.

[ghstack-poisoned]
@ZolotukhinM ZolotukhinM requested a review from apaszke as a code owner August 6, 2020 18:15
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 6, 2020
@dr-ci
Copy link

dr-ci bot commented Aug 6, 2020

💊 CI failures summary and remediations

As of commit 73d215b (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 6 times.

Both the profiling executor and the legacy executor have the debug
loggin now.

Ideally, if we had a pass manager, this could be done as a part of it,
but since we have none, I had to insert the debug statements manually.

[ghstack-poisoned]
Both the profiling executor and the legacy executor have the debug
loggin now.

Ideally, if we had a pass manager, this could be done as a part of it,
but since we have none, I had to insert the debug statements manually.

Differential Revision: [D22981675](https://our.internmc.facebook.com/intern/diff/D22981675)

[ghstack-poisoned]
ZolotukhinM pushed a commit that referenced this pull request Aug 6, 2020
Both the profiling executor and the legacy executor have the debug
loggin now.

Ideally, if we had a pass manager, this could be done as a part of it,
but since we have none, I had to insert the debug statements manually.

ghstack-source-id: 6136c5a
Pull Request resolved: #42688
@facebook-github-bot
Copy link
Contributor

@ZolotukhinM merged this pull request in cc596ac.

@facebook-github-bot facebook-github-bot deleted the gh/ZolotukhinM/287/head branch August 10, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants