Skip to content

Add Rowwise Prune PyTorch op #42708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add Rowwise Prune PyTorch op #42708

wants to merge 1 commit into from

Conversation

radkris-git
Copy link

Summary:
Add rowwise prune pytorch op.

This operator introduces sparsity to the 'weights' matrix with the help
of the importance indicator 'mask'.

A row is considered important and not pruned if the mask value for that
particular row is 1(True) and not important otherwise.

Test Plan:
buck test caffe2/torch/fb/sparsenn:test -- rowwise_prune
buck test caffe2/test:pruning

Differential Revision: D22849432

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22849432

@dr-ci
Copy link

dr-ci bot commented Aug 7, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit e403b0d (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 52 times.

raghuramank100
raghuramank100 reviewed Aug 7, 2020
View reviewed changes
raghuramank100
raghuramank100 reviewed Aug 7, 2020
View reviewed changes
raghuramank100
raghuramank100 reviewed Aug 7, 2020
View reviewed changes
raghuramank100
raghuramank100 suggested changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@raghuramank100 raghuramank100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

supriyar
supriyar reviewed Aug 14, 2020
View reviewed changes
@radkris-git
Copy link
Author

Addressed comments.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22849432

supriyar
supriyar reviewed Aug 18, 2020
View reviewed changes
supriyar
supriyar reviewed Aug 18, 2020
View reviewed changes
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22849432

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22849432

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22849432

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22849432

@radkris-git radkris-git requested a review from supriyar August 19, 2020 18:12
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22849432

@facebook-github-bot
Add Rowwise Prune PyTorch op (pytorch#42708)
e403b0d 
Summary:
Pull Request resolved: pytorch#42708

Add rowwise prune pytorch op.

This operator introduces sparsity to the 'weights' matrix with the help
of the importance indicator 'mask'.

A row is considered important and not pruned if the mask value for that
particular row is 1(True) and not important otherwise.

Test Plan:
buck test caffe2/torch/fb/sparsenn:test -- rowwise_prune
buck test caffe2/test:pruning

Reviewed By: supriyar

Differential Revision: D22849432

fbshipit-source-id: b9eaa128fd8b8d63cf1aa2270dbb23f7816bf79d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22849432

albanD added a commit to albanD/pytorch that referenced this pull request Oct 9, 2020
@albanD
Revert "Add Rowwise Prune PyTorch op (pytorch#42708)"
d789212 
This reverts commit 8032dbc.
malfet pushed a commit that referenced this pull request Oct 12, 2020
@albanD
Revert "Add Rowwise Prune PyTorch op (#42708)" (#46103)
445ba03 
This reverts commit 8032dbc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@supriyar supriyar supriyar approved these changes

@raghuramank100 raghuramank100 Awaiting requested review from raghuramank100

Assignees

No one assigned

Labels

fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@radkris-git @facebook-github-bot @supriyar @raghuramank100