[ONNX] Modified slice node in inplace ops pass #43275
Conversation
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit 8af31c5 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 11 times. |
|
LG, please fix the lint failure. |
…kare/slice_export_bug
…kare/slice_export_bug
…kare/slice_export_bug
|
@bzinodev build failure seems unrelated to changes made in code |
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| auto start = slice->get(attr::start) ? slice->get(attr::start) : 0; | ||
| auto end = slice->get(attr::end) ? slice->get(attr::end) : int_max; | ||
| auto step = slice->get(attr::step); | ||
| TORCH_INTERNAL_ASSERT((slice->inputs()).size() == 5); |
There was a problem hiding this comment.
How about the opset < 11, if we set start and end as arguments, not inputs
There was a problem hiding this comment.
For this pass the operator is aten::slice, start/end/step would always be inputs. The function
ConvertSliceToIndex is only called on encountering an index_put node.
|
@houseroad merged this pull request in 9ca338a. |
7 participants
Fixes #42292