Convert StoreTestUtils to Gtest #43382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StoreTestCommon defines standard helper functions that are used by all of our Store tests. These helpers currently throw exceptions upon failure, this PR changes them to use gtest assertions instead. Differential Revision: [D22828156](https://our.internmc.facebook.com/intern/diff/D22828156/) [ghstack-poisoned]
osalpekar
requested review from
mrshenli,
pietern and
zhaojuanmao
as code owners
This was referenced Aug 21, 2020
💊 CI failures summary and remediationsAs of commit 6579e72 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 26 times. |
StoreTestCommon defines standard helper functions that are used by all of our Store tests. These helpers currently throw exceptions upon failure, this PR changes them to use gtest assertions instead. Differential Revision: [D22828156](https://our.internmc.facebook.com/intern/diff/D22828156/) [ghstack-poisoned]
StoreTestCommon defines standard helper functions that are used by all of our Store tests. These helpers currently throw exceptions upon failure, this PR changes them to use gtest assertions instead. Differential Revision: [D22828156](https://our.internmc.facebook.com/intern/diff/D22828156/) [ghstack-poisoned]
StoreTestCommon defines standard helper functions that are used by all of our Store tests. These helpers currently throw exceptions upon failure, this PR changes them to use gtest assertions instead. Differential Revision: [D22828156](https://our.internmc.facebook.com/intern/diff/D22828156/) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/osalpekar/73/base #43382 +/- ##
=====================================================
Coverage 67.99% 67.99%
=====================================================
Files 382 382
Lines 49380 49380
=====================================================
Hits 33578 33578
Misses 15802 15802 Continue to review full report at Codecov.
|
pritamdamania87
approved these changes
Sep 2, 2020
jiayisuse
approved these changes
Sep 9, 2020
StoreTestCommon defines standard helper functions that are used by all of our Store tests. These helpers currently throw exceptions upon failure, this PR changes them to use gtest assertions instead. Differential Revision: [D22828156](https://our.internmc.facebook.com/intern/diff/D22828156/) [ghstack-poisoned]
|
This pull request has been merged in a7fba7d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
StoreTestCommon defines standard helper functions that are used by all of our Store tests. These helpers currently throw exceptions upon failure, this PR changes them to use gtest assertions instead.
Differential Revision: D22828156