[ONNX] Fix view for dynamic input shape

[neginraoof]

Export of view op with dynamic input shape is broken when using tensors with a 0-dim.
This fix removes symbolic use of static input size to fix this issue.

[dr-ci]

💊 CI failures summary and remediations

As of commit bb3b5b7 (more details on the Dr. CI page):

---

• 2/2 failures possibly* introduced in this PR
  • 2/2 non-CircleCI failure(s)

---

Extra GitHub checks: 1 failed

• Failed: Codecov - codecov/patch

---

codecov.io: 1 failed

• Failed: codecov/patch

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 57 times.

[BowenBao]

failed tests may be related

Aug 27 19:29:00 FAILED test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset7::test_view_dynamic_zero_dim
Aug 27 19:29:00 FAILED test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset8::test_view_dynamic_zero_dim

[codecov]

Codecov Report

Merging #43558 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #43558      +/-   ##
==========================================
+ Coverage   67.85%   67.87%   +0.01%     
==========================================
  Files         384      384              
  Lines       50020    50005      -15     
==========================================
- Hits        33942    33939       -3     
+ Misses      16078    16066      -12     

Impacted Files	Coverage Δ
torch/onnx/symbolic_opset12.py	25.00% <0.00%> (ø)
torch/onnx/symbolic_opset8.py	30.00% <0.00%> (+1.34%)	⬆️
torch/onnx/symbolic_opset9.py	34.85% <0.00%> (+0.08%)	⬆️
torch/utils/_benchmark/utils/common.py	77.68% <0.00%> (-1.66%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6895d4...bb3b5b7. Read the comment docs.

[neginraoof]

cc @bzinodev Jenkins failures are unrelated. Can we re-trigger these to unblock merge?

[BowenBao]

Test failures are related, seems related to my last suggestion.

[BowenBao]

test failures seem related

[neginraoof]

@BowenBao
Thanks! I updated the symbolic. Looks like the line size = sym_help._maybe_get_const(size, 'is') in view symbolic is required to handle cases where the view size is an empty list.

[BowenBao]

LGTM, thanks!

[facebook-github-bot]

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@bzinodev merged this pull request in a77d633.