[reland][quant][graphmode][fx] Add support for weight prepack folding (#43728) #43902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#43728) Summary: Trace back from the weight node util we hit getattr, reconstruct the graph module with the traced nodes and run the graph module to pack the weight. then replace the original chain of ops with the packed weight. Test Plan: Imported from OSS Reviewed By: vkuzo [ghstack-poisoned]
vkuzo
approved these changes
Aug 31, 2020
💊 CI failures summary and remediationsAs of commit cfba9f6 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 5 times. |
…ack folding (#43728)" Summary: Trace back from the weight node util we hit getattr, reconstruct the graph module with the traced nodes and run the graph module to pack the weight. then replace the original chain of ops with the packed weight. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: [D23432431](https://our.internmc.facebook.com/intern/diff/D23432431) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Aug 31, 2020
…#43728) Summary: Trace back from the weight node util we hit getattr, reconstruct the graph module with the traced nodes and run the graph module to pack the weight. then replace the original chain of ops with the packed weight. Test Plan: Imported from OSS Reviewed By: vkuzo ghstack-source-id: a0c8926 Pull Request resolved: #43902
Codecov Report
@@ Coverage Diff @@
## gh/jerryzh168/422/base #43902 +/- ##
==========================================================
+ Coverage 69.25% 69.30% +0.04%
==========================================================
Files 379 379
Lines 46926 46992 +66
==========================================================
+ Hits 32498 32566 +68
+ Misses 14428 14426 -2
Continue to review full report at Codecov.
|
|
This pull request has been merged in 825c109. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Trace back from the weight node util we hit getattr, reconstruct the graph module with the traced nodes
and run the graph module to pack the weight. then replace the original chain of ops with the packed weight.
Test Plan: Imported from OSS
Reviewed By: vkuzo
Differential Revision: D23432431