Skip to content

Conversation

t-vi
Copy link
Collaborator

@t-vi t-vi commented Sep 4, 2020

Fixes a broken skipTest from #43451, e.g. in the ROCm CI.

@dr-ci
Copy link

dr-ci bot commented Sep 4, 2020

💊 CI failures summary and remediations

As of commit e9cd237 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 5 times.

@t-vi
Copy link
Collaborator Author

t-vi commented Sep 4, 2020

Hmhm. doesn't completely fix this, though.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in 7c61f57.

@t-vi
Copy link
Collaborator Author

t-vi commented Sep 8, 2020

@malfet Thank you! I wasn't sure whether we'd use f-strings, but they sure are nice here. Thank you for fixing this, too.

@malfet
Copy link
Contributor

malfet commented Sep 8, 2020

@t-vi Since 1.6 release, PyTorch can use any feature present in Python-3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants