Skip to content

Update backward definition for more operators and reenable tests in test_ops.py #44444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

Update backward definition for more operators and reenable tests in test_ops.py #44444

wants to merge 17 commits into from

Conversation

anjali411
Copy link
Contributor

@anjali411 anjali411 commented Sep 10, 2020 •
edited
Loading

Stack from ghstack:

This PR:

  1. Fixes [Complex Autograd] pow_backward functions throw error for complex dtypes #41510. Updates backward formula for the following functions: asin, acos, asinh, acosh, atan, atanh, div, log, log10, log2, log1p, pow (fixes [Complex Autograd] pow_backward functions throw error for complex dtypes #41510 ), reciprocal, angle.
  2. Re-enables the tests in test_ops.py.
  3. Adds dispatch for complex dtypes for tanh_backward.
  4. Re-enables commented tests in common_methods_invocation.py.

Differential Revision: D24027761

@anjali411 anjali411 mentioned this pull request Sep 10, 2020
Closed
7 tasks
anjali411 added a commit that referenced this pull request Sep 10, 2020
@anjali411
Update backward definition for more operators and reenable tests in t…
d984c08 
…est_ops.py

ghstack-source-id: 5f4ed74
Pull Request resolved: #44444
@dr-ci
Copy link

dr-ci bot commented Sep 10, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 82ad2f8 (more details on the Dr. CI page):

Commit 82ad2f8 was recently pushed. Waiting for builds...

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 107 times.

anjali411 added a commit that referenced this pull request Sep 10, 2020
@anjali411
Update backward definition for more operators and reenable tests in t…
872dd0d 
…est_ops.py

ghstack-source-id: d94b130
Pull Request resolved: #44444
anjali411 added a commit that referenced this pull request Sep 11, 2020
@anjali411
Update backward definition for more operators and reenable tests in t…
e767730 
…est_ops.py

ghstack-source-id: d33ddaf
Pull Request resolved: #44444
anjali411 added a commit that referenced this pull request Sep 11, 2020
@anjali411
Update backward definition for more operators and reenable tests in t…
b8e455b 
…est_ops.py

ghstack-source-id: 2c2061f
Pull Request resolved: #44444
@anjali411 anjali411 changed the title Update backward definition for more operators and reenable tests in test_ops.py [WIP] Update backward definition for more operators and reenable tests in test_ops.py Sep 11, 2020
@anjali411
Update on "[WIP] Update backward definition for more operators and re…
839a73b 
…enable tests in test_ops.py"

[ghstack-poisoned]
anjali411 added a commit that referenced this pull request Sep 14, 2020
@anjali411
Update backward definition for more operators and reenable tests in t…
6cad06c 
…est_ops.py

ghstack-source-id: e4a6a17
Pull Request resolved: #44444
@anjali411
Update on "[WIP] Update backward definition for more operators and re…
4e168d9 
…enable tests in test_ops.py"

[ghstack-poisoned]
anjali411 added a commit that referenced this pull request Sep 14, 2020
@anjali411
Update backward definition for more operators and reenable tests in t…
4815eca 
…est_ops.py

ghstack-source-id: 7b4f5af
Pull Request resolved: #44444
@anjali411
Update on "[WIP] Update backward definition for more operators and re…
bac1834 
…enable tests in test_ops.py"


This PR:
1. updates backward formula for the following functions: `asin`, `acos`, `asinh`, `acosh`, `atan`, `atanh`, `div`, `log`, `log10`, `log2`, `log1p`, `pow`.
2. Re-enables the tests in `test_ops.py`.
3. Fixes a bug in `.pow()` for the case when exp is complex and equals 1.0 https://github.com/pytorch/pytorch/pull/44444/files#diff-9fa1985487308c7241bba078a8622c44L33 .
4. Adds dispatch for complex dtypes for `tanh`.
5. Re-enables commented tests in `common_methods_invocation.py`.


[ghstack-poisoned]
anjali411 added a commit that referenced this pull request Sep 15, 2020
@anjali411
Update backward definition for more operators and reenable tests in t…
9c94d3c 
…est_ops.py

ghstack-source-id: 971673a
Pull Request resolved: #44444
@anjali411 anjali411 mentioned this pull request Sep 15, 2020
Closed
@anjali411
Update on "[WIP] Update backward definition for more operators and re…
11729bc 
…enable tests in test_ops.py"


This PR:
1. updates backward formula for the following functions: `asin`, `acos`, `asinh`, `acosh`, `atan`, `atanh`, `div`, `log`, `log10`, `log2`, `log1p`, `pow`.
2. Re-enables the tests in `test_ops.py`.
3. Fixes a bug in `.pow()` for the case when exp is complex and equals 1.0 https://github.com/pytorch/pytorch/pull/44444/files#diff-9fa1985487308c7241bba078a8622c44L33 .
4. Adds dispatch for complex dtypes for `tanh`.
5. Re-enables commented tests in `common_methods_invocation.py`.


[ghstack-poisoned]
@anjali411
Update on "[WIP] Update backward definition for more operators and re…
488a017 
…enable tests in test_ops.py"


This PR:
1. updates backward formula for the following functions: `asin`, `acos`, `asinh`, `acosh`, `atan`, `atanh`, `div`, `log`, `log10`, `log2`, `log1p`, `pow`, `reciprocal`.
2. Re-enables the tests in `test_ops.py`.
3. Fixes a bug in `.pow()` for the case when exp is complex and equals 1.0 https://github.com/pytorch/pytorch/pull/44444/files#diff-9fa1985487308c7241bba078a8622c44L33 .
4. Adds dispatch for complex dtypes for `tanh_backward`.
5. Re-enables commented tests in `common_methods_invocation.py`.


[ghstack-poisoned]
@anjali411
Update on "[WIP] Update backward definition for more operators and re…
0d15613 
…enable tests in test_ops.py"


This PR:
1. updates backward formula for the following functions: `asin`, `acos`, `asinh`, `acosh`, `atan`, `atanh`, `div`, `log`, `log10`, `log2`, `log1p`, `pow`, `reciprocal`.
2. Re-enables the tests in `test_ops.py`.
3. Fixes a bug in `.pow()` for the case when exp is complex and equals 1.0 https://github.com/pytorch/pytorch/pull/44444/files#diff-9fa1985487308c7241bba078a8622c44L33 .
4. Adds dispatch for complex dtypes for `tanh_backward`.
5. Re-enables commented tests in `common_methods_invocation.py`.


[ghstack-poisoned]
@anjali411 anjali411 added complex_autograd module: complex Related to complex number support in PyTorch labels Sep 30, 2020
@anjali411 anjali411 added this to the 1.7.0 milestone Sep 30, 2020
@anjali411
Update on "Update backward definition for more operators and reenable…
82ad2f8 
… tests in test_ops.py"


This PR:
1. Fixes #41510. Updates backward formula for the following functions: `asin`, `acos`, `asinh`, `acosh`, `atan`, `atanh`, `div`, `log`, `log10`, `log2`, `log1p`, `pow` (fixes #41510 ), `reciprocal`, `angle`.
2. Re-enables the tests in `test_ops.py`.
3. Adds dispatch for complex dtypes for `tanh_backward`.
4. Re-enables commented tests in `common_methods_invocation.py`.

Differential Revision: [D24027761](https://our.internmc.facebook.com/intern/diff/D24027761)

[ghstack-poisoned]
@anjali411 anjali411 requested a review from albanD October 1, 2020 19:57
albanD
albanD approved these changes Oct 2, 2020
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@facebook-github-bot
Copy link
Contributor

@anjali411 merged this pull request in 7d809f5.

@ezyang
Copy link
Contributor

ezyang commented Oct 3, 2020

Unfortunately this is failing Windows only test:

======================================================================
FAIL [0.017s]: test_grad_scaling_penalty (__main__.TestCuda)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_cuda.py", line 2145, in test_grad_scaling_penalty
    self._run_scaling_case(run, unskipped=3, skipped=1)
  File "test_cuda.py", line 2036, in _run_scaling_case
    self.assertTrue(torch.allclose(c, s, atol=atol))
AssertionError: False is not true

----------------------------------------------------------------------

@anjali411 anjali411 mentioned this pull request Oct 5, 2020
Merged
@facebook-github-bot facebook-github-bot deleted the gh/anjali411/54/head branch October 6, 2020 14:21
@anjali411 anjali411 mentioned this pull request Oct 13, 2020
Closed
@anjali411 anjali411 restored the gh/anjali411/54/head branch October 13, 2020 18:32
This was referenced Oct 13, 2020
Closed
Closed
anjali411 added a commit that referenced this pull request Oct 13, 2020
@anjali411
Update backward formulas (Re #44444)
87fedc4 
[ghstack-poisoned]
anjali411 added a commit that referenced this pull request Oct 13, 2020
@anjali411
Update backward formulas (Re #44444)
d52e35b 
ghstack-source-id: 3090118
Pull Request resolved: #46275
anjali411 added a commit that referenced this pull request Oct 14, 2020
@anjali411
Update on "Update backward formulas (Re #44444)"
732e20d 
Re #44444 
Fixes #46144

Differential Revision: [D24285785](https://our.internmc.facebook.com/intern/diff/D24285785)

[ghstack-poisoned]
anjali411 added a commit that referenced this pull request Oct 14, 2020
@anjali411
Update on "Update backward formulas (Re #44444)"
c673cdc 
Re #44444 
Fixes #46144

Differential Revision: [D24285785](https://our.internmc.facebook.com/intern/diff/D24285785)

[ghstack-poisoned]
anjali411 added a commit that referenced this pull request Oct 14, 2020
@anjali411
Update backward formulas (Re #44444)
c441858 
ghstack-source-id: 333568d
Pull Request resolved: #46275
anjali411 added a commit that referenced this pull request Oct 16, 2020
@anjali411
Update backward formulas (Re #44444)
9df841e 
ghstack-source-id: 333568d
Pull Request resolved: #46275
anjali411 added a commit that referenced this pull request Oct 20, 2020
@anjali411
Update backward formulas (Re #44444)
20ecd44 
ghstack-source-id: 333568d
Pull Request resolved: #46275
anjali411 added a commit that referenced this pull request Oct 21, 2020
@anjali411
Update backward formulas (Re #44444)
93dbd06 
ghstack-source-id: 333568d
Pull Request resolved: #46275
anjali411 added a commit that referenced this pull request Oct 23, 2020
@anjali411
Update backward formulas (Re #44444)
c7f8a05 
ghstack-source-id: beaaf0d
Pull Request resolved: #46275
anjali411 added a commit that referenced this pull request Oct 23, 2020
@anjali411
Update on "Update backward formulas (Re #44444)"
0377256 
Re #44444 
Fixes #46144

Differential Revision: [D24285785](https://our.internmc.facebook.com/intern/diff/D24285785)

[ghstack-poisoned]
anjali411 added a commit that referenced this pull request Oct 25, 2020
@anjali411
Update backward formulas (Re #44444)
4ad0a96 
ghstack-source-id: 9277862
Pull Request resolved: #46275
anjali411 added a commit that referenced this pull request Oct 25, 2020
@anjali411
Update on "Update backward formulas (Re #44444)"
491359f 
Re #44444 
Fixes #46144

Differential Revision: [D24285785](https://our.internmc.facebook.com/intern/diff/D24285785)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Oct 26, 2020
@anjali411 @facebook-github-bot
Update backward formulas (Re #44444) (#46275)
d94bd99 
Summary:
Pull Request resolved: #46275

Re #44444

Test Plan: Imported from OSS

Reviewed By: zou3519

Differential Revision: D24285785

Pulled By: anjali411

fbshipit-source-id: c60ecd4fe4f144132085f2c91d3b950e92b2a491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

complex_autograd Merged module: complex Related to complex number support in PyTorch

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@anjali411 @facebook-github-bot @ezyang @albanD @mruberry