Skip to content

Update submodule gloo to have latest commits to enable it can work on Windows #44529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Update submodule gloo to have latest commits to enable it can work on Windows #44529

wants to merge 6 commits into from

Conversation

gunandrose4u
Copy link
Contributor

Fixes #{issue number}

gunandrose4u and others added 6 commits August 17, 2020 11:27
@gunandrose4u
Merge pull request #1 from pytorch/master
bf02d77 
Update my fork from Pytorch repo
@gunandrose4u
Merge pull request #2 from pytorch/master
2ebe620 
Rebase from pytorch/pytorch master
@gunandrose4u
Merge pull request #3 from pytorch/master
04f7b51 
Rebase latest code from master branch of PyTorch repo
@gunandrose4u
Merge pull request #4 from pytorch/master
afbc6c1 
Rebase code
@gunandrose4u
Merge pull request #5 from pytorch/master
c933f32 
Rebase to latest commits
@gunandrose4u
Update submodule gloo to have latest commits to enable it can work on…
f388720 
… Windows
@gunandrose4u
Copy link
Contributor Author

@mrshenli , please help to review this PR for updating gloo submodule to include latest commits to enable it working on Windows. Thank you!

@codecov
Copy link

codecov bot commented Sep 11, 2020 •
edited
Loading

Codecov Report

Merging #44529 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #44529   +/-   ##
=======================================
  Coverage   68.00%   68.00%           
=======================================
  Files         382      382           
  Lines       49527    49527           
=======================================
+ Hits        33679    33680    +1     
+ Misses      15848    15847    -1
Impacted Files Coverage Δ
torch/testing/_internal/expecttest.py 78.57% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69f6d94...f388720. Read the comment docs.

facebook-github-bot
facebook-github-bot reviewed Sep 11, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mrshenli merged this pull request in 9a3b83c.

@gunandrose4u gunandrose4u deleted the jozh/update_gloo_submodule branch September 18, 2020 15:55
xuzhao9 pushed a commit that referenced this pull request Sep 18, 2020
@gunandrose4u @xuzhao9
Update submodule gloo to have latest commits to enable it can work on…
ccd2708 
… Windows (#44529)

Summary:
Fixes #{issue number}

Pull Request resolved: #44529

Reviewed By: rohan-varma

Differential Revision: D23650123

Pulled By: mrshenli

fbshipit-source-id: b5b891cbcec51a14379d6604af63c714c32d93e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@mrshenli mrshenli mrshenli approved these changes

Assignees

No one assigned

Labels

Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gunandrose4u @facebook-github-bot @mrshenli @pytorchbot @mruberry