Check for index-rank consistency in FunctionInliner #44561
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asuhan
changed the title
asuhan
force-pushed
the
asuhan/check_arity_of_inline
branch
2 times, most recently
from
771379b to
bd3e465
Compare
ZolotukhinM
reviewed
Sep 11, 2020
There was a problem hiding this comment.
@nickgg has been actively working on this recently, so I'd be more comfortable if he could review this
facebook-github-bot
added
the
oncall: jit
|
Looks fine, but this code is removed in #44231. Can you add a test to make sure that PR doesn't regress on this issue? |
Summary: When caller / callee pairs are inserted into the mapping, verify that the arity of the buffer access is consistent with its declared rank. Test Plan: CI, test_tensorexpr --gtest_filter=TensorExprTest.DetectInlineRankMismatch
asuhan
force-pushed
the
asuhan/check_arity_of_inline
branch
from
bd3e465 to
1aba169
Compare
|
@nickgg Added a test for the error path. |
Codecov Report
@@ Coverage Diff @@
## master #44561 +/- ##
=======================================
Coverage 67.97% 67.97%
=======================================
Files 384 384
Lines 49589 49589
=======================================
Hits 33710 33710
Misses 15879 15879 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@asuhan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
xuzhao9
pushed a commit
that referenced
this pull request
Sep 18, 2020
Summary: When caller / callee pairs are inserted into the mapping, verify that the arity of the buffer access is consistent with its declared rank. Pull Request resolved: #44561 Test Plan: CI, test_tensorexpr --gtest_filter=TensorExprTest.DetectInlineRankMismatch Reviewed By: albanD Differential Revision: D23684342 Pulled By: asuhan fbshipit-source-id: dd3a0cdd4c2492853fa68381468e0ec037136cab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: When caller / callee pairs are inserted into the mapping, verify that
the arity of the buffer access is consistent with its declared rank.
Test Plan: CI, test_tensorexpr --gtest_filter=TensorExprTest.DetectInlineRankMismatch