-
Notifications
You must be signed in to change notification settings - Fork 25.6k
added rocm 3.8 docker image #45205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added rocm 3.8 docker image #45205
Conversation
💊 CI failures summary and remediationsAs of commit 76e5fb9 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 1 failure confirmed as flaky and can be ignored:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 6 times. |
@ezyang looks like our image build is failing because the valgrind tarball URL is no longer working. Are we okay updating this to the latest valgrind release version 3.16.1? I believe that would update all images, but I'm surprised we haven't seen this fail for any other image yet. |
@walterddr or @malfet , do you have an opinion on whether we can use a newer valgrind to resolve our image build issue? |
@jeffdaily please update the valgrind URI to the latest version and I will try to land the change |
@ezyang or @seemethere , we need the AWS ECR entry created for our new image. |
Should be added now |
Codecov Report
@@ Coverage Diff @@
## master #45205 +/- ##
=======================================
Coverage 67.88% 67.88%
=======================================
Files 384 384
Lines 50108 50108
=======================================
Hits 34016 34016
Misses 16092 16092 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@walterddr merged this pull request in c79d493. |
@jeffdaily