Skip to content

Conversation

KyleCZH
Copy link
Contributor

@KyleCZH KyleCZH commented Sep 23, 2020

@dr-ci
Copy link

dr-ci bot commented Sep 23, 2020

💊 CI failures summary and remediations

As of commit 76e5fb9 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


1 failure confirmed as flaky and can be ignored:

  • docker-pytorch-linux-bionic-rocm3.8-py3.6

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 6 times.

@ezyang ezyang requested review from jeffdaily and malfet September 23, 2020 19:17
@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 23, 2020
@jeffdaily
Copy link
Collaborator

@ezyang looks like our image build is failing because the valgrind tarball URL is no longer working. Are we okay updating this to the latest valgrind release version 3.16.1? I believe that would update all images, but I'm surprised we haven't seen this fail for any other image yet.

@jeffdaily
Copy link
Collaborator

@walterddr or @malfet , do you have an opinion on whether we can use a newer valgrind to resolve our image build issue?

@malfet
Copy link
Contributor

malfet commented Sep 23, 2020

@jeffdaily please update the valgrind URI to the latest version and I will try to land the change

@jeffdaily
Copy link
Collaborator

@ezyang or @seemethere , we need the AWS ECR entry created for our new image. pytorch/pytorch-linux-bionic-rocm3.8-py3.6 That's why the build is failing. The image push was failing, but the dr-ci bot was showing the failure as the valgrind download. That was the confusion.

@ezyang
Copy link
Contributor

ezyang commented Sep 24, 2020

Should be added now

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #45205 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #45205   +/-   ##
=======================================
  Coverage   67.88%   67.88%           
=======================================
  Files         384      384           
  Lines       50108    50108           
=======================================
  Hits        34016    34016           
  Misses      16092    16092           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c68a7...76e5fb9. Read the comment docs.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@walterddr merged this pull request in c79d493.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants