-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Move mobile specific CPUCachingAllocator to c10/mobile folder. #45364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request was exported from Phabricator. Differential Revision: D23944193 |
💊 CI failures summary and remediationsAs of commit e81b8a8 (more details on the Dr. CI page):
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
e185537
to
2041342
Compare
This pull request was exported from Phabricator. Differential Revision: D23944193 |
Codecov Report
@@ Coverage Diff @@
## master #45364 +/- ##
==========================================
+ Coverage 68.15% 68.38% +0.22%
==========================================
Files 396 405 +9
Lines 51133 51765 +632
==========================================
+ Hits 34851 35399 +548
- Misses 16282 16366 +84
Continue to review full report at Codecov.
|
c10/mobile/CPUCachingAllocator.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: did you mean: "It has been observed that some mobile platforms, such as pixel 3", return ..."
c10/mobile/CPUCachingAllocator.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you put a brief summary of the disclaimer first, like:
`DISCLAIMER: this is subject to change (beta) and only supported on mobile builds. See below for more information"
This pull request was exported from Phabricator. Differential Revision: D23944193 |
2041342
to
588683e
Compare
…ch#45364) Summary: Pull Request resolved: pytorch#45364 Plus add some more comments about the usage, limitations and cons. Test Plan: Build and run benchmark binary. Reviewed By: gchanan Differential Revision: D23944193 fbshipit-source-id: 25d91f4ca0ede4c48cb96faff3a830f1260b41b2
This pull request was exported from Phabricator. Differential Revision: D23944193 |
588683e
to
e81b8a8
Compare
This pull request has been merged in 6e55a26. |
1 similar comment
This pull request has been merged in 6e55a26. |
Summary: Plus add some more comments about the usage, limitations and cons.
Test Plan: Build and run benchmark binary.
Differential Revision: D23944193