Skip to content

Conversation

kimishpatel
Copy link
Contributor

Summary: Plus add some more comments about the usage, limitations and cons.

Test Plan: Build and run benchmark binary.

Differential Revision: D23944193

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23944193

@dr-ci
Copy link

dr-ci bot commented Sep 25, 2020

💊 CI failures summary and remediations

As of commit e81b8a8 (more details on the Dr. CI page):



❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_ios_11_2_1_x86_64_build (1/1)

Step: "Update Homebrew" (full log | diagnosis details | 🔁 rerun) ❄️

fatal: Could not read from remote repository.
Receiving objects:  98% (175/178) Receiving objects:  99% (177/178) Receiving objects: 100% (178/178) Receiving objects: 100% (178/178), 63.88 KiB | 10.65 MiB/s, done. 
Resolving deltas:  96% (89/92) Resolving deltas:  97% (90/92) Resolving deltas: 100% (92/92) Resolving deltas: 100% (92/92), completed with 85 local objects. 
From ssh://github.com/Homebrew/homebrew-cask-versions 
 + 15f6b44...92646be master     -> origin/master  (forced update) 
+ git reset --hard origin/master 
HEAD is now at 92646be Update dropbox-beta from 107.3.412 to 107.3.416 (#9683) 
+ for path in '$(find /usr/local/Homebrew -type d -name .git)' 
+ cd /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/.git/.. 
+ git fetch --depth=1 origin 
Connection to github.com closed by remote host.  
fatal: Could not read from remote repository. 
 
Please make sure you have the correct access rights 
and the repository exists. 

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 12 times.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23944193

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #45364 into master will increase coverage by 0.22%.
The diff coverage is 79.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #45364      +/-   ##
==========================================
+ Coverage   68.15%   68.38%   +0.22%     
==========================================
  Files         396      405       +9     
  Lines       51133    51765     +632     
==========================================
+ Hits        34851    35399     +548     
- Misses      16282    16366      +84     
Impacted Files Coverage Δ
torch/distributed/__init__.py 87.50% <ø> (ø)
torch/functional.py 88.21% <ø> (-0.08%) ⬇️
torch/onnx/symbolic_opset10.py 36.25% <0.00%> (ø)
torch/testing/_internal/common_nn.py 83.50% <0.00%> (+0.16%) ⬆️
torch/_lobpcg.py 69.50% <16.66%> (-16.84%) ⬇️
torch/onnx/symbolic_opset9.py 35.47% <22.22%> (+0.68%) ⬆️
...orch/testing/_internal/codegen/random_topo_test.py 10.04% <50.00%> (+0.41%) ⬆️
torch/onnx/symbolic_helper.py 42.76% <60.00%> (-0.10%) ⬇️
torch/optim/_multi_tensor/sgd.py 90.27% <90.27%> (ø)
torch/optim/_multi_tensor/adamax.py 91.37% <91.37%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cde662...e81b8a8. Read the comment docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: did you mean: "It has been observed that some mobile platforms, such as pixel 3", return ..."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you put a brief summary of the disclaimer first, like:

`DISCLAIMER: this is subject to change (beta) and only supported on mobile builds. See below for more information"

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23944193

@gchanan gchanan added this to the 1.7.0 milestone Sep 29, 2020
…ch#45364)

Summary:
Pull Request resolved: pytorch#45364

Plus add some more comments about the usage, limitations and cons.

Test Plan: Build and run benchmark binary.

Reviewed By: gchanan

Differential Revision: D23944193

fbshipit-source-id: 25d91f4ca0ede4c48cb96faff3a830f1260b41b2
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23944193

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6e55a26.

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6e55a26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants