-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Unify Transformer coder Constructors #45515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Transformer coder Constructors #45515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glaringlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
💊 CI failures summary and remediationsAs of commit 8c86ac6 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 2 failures confirmed as flaky and can be ignored:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 7 times. |
💊 CI failures summary and remediationsAs of commit 653941d1e4 (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_bionic_py3_6_clang9_build is failing. Please create an issue with title prefixed by This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. |
653941d
to
8c86ac6
Compare
Codecov Report
@@ Coverage Diff @@
## master #45515 +/- ##
==========================================
- Coverage 68.56% 68.55% -0.01%
==========================================
Files 405 405
Lines 51955 51955
==========================================
- Hits 35621 35620 -1
- Misses 16334 16335 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glaringlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@glaringlee merged this pull request in e02868e. |
Fixes #{45502}