Skip to content

Conversation

neginraoof
Copy link
Contributor

Adding export for var, var_mean and std_mean ops

@mrshenli mrshenli added module: onnx Related to torch.onnx triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Oct 1, 2020
@mrshenli mrshenli requested a review from houseroad October 1, 2020 23:58
@BowenBao
Copy link
Collaborator

BowenBao commented Oct 3, 2020

CI test failure seems related

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #45678 into master will decrease coverage by 0.01%.
The diff coverage is 10.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #45678      +/-   ##
==========================================
- Coverage   68.17%   68.16%   -0.02%     
==========================================
  Files         410      410              
  Lines       53422    53438      +16     
==========================================
+ Hits        36422    36426       +4     
- Misses      17000    17012      +12     
Impacted Files Coverage Δ
torch/onnx/symbolic_opset9.py 35.22% <10.81%> (-0.17%) ⬇️
torch/testing/_internal/expecttest.py 78.57% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59414b3...256d8c6. Read the comment docs.

@dr-ci
Copy link

dr-ci bot commented Oct 9, 2020

💊 CI failures summary and remediations

As of commit 256d8c6 (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

Extra GitHub checks: 1 failed


codecov.io: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 14 times.

Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@bzinodev merged this pull request in 96bc7fa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: onnx Related to torch.onnx open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants