Skip to content

[JIT] Bind log1p and lgamma #45791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[JIT] Bind log1p and lgamma #45791

wants to merge 5 commits into from

Conversation

eellison
Copy link
Contributor

@eellison eellison commented Oct 2, 2020 •
edited
Loading

Stack from ghstack:

Most of the lowering for log1p and lgamma already existed, add JIT integration.

Differential Revision: D24169536

Bind log1p and lgamma
8d663b4 
[ghstack-poisoned]
@eellison eellison requested a review from apaszke as a code owner October 2, 2020 23:49
This was referenced Oct 2, 2020
Closed
Closed
Closed
eellison pushed a commit that referenced this pull request Oct 2, 2020
Bind log1p and lgamma
21488f1 
ghstack-source-id: 73653ea
Pull Request resolved: #45791
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Oct 2, 2020
eellison pushed a commit that referenced this pull request Oct 5, 2020
Bind log1p and lgamma
b8f201d 
ghstack-source-id: fd6878f
Pull Request resolved: #45791
@eellison eellison changed the title Bind log1p and lgamma [JIT] Bind log1p and lgamma Oct 5, 2020
Update on "[JIT] Bind log1p and lgamma"
961d7d7 
Most of the lowering for log1p and lgamma already existed, add JIT integration.


[ghstack-poisoned]
eellison pushed a commit that referenced this pull request Oct 5, 2020
Bind log1p and lgamma
638a633 
ghstack-source-id: 84a195d
Pull Request resolved: #45791
@Krovatkin Krovatkin self-requested a review October 6, 2020 16:52
Krovatkin
Krovatkin approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@Krovatkin Krovatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Update on "[JIT] Bind log1p and lgamma"
3260611 
Most of the lowering for log1p and lgamma already existed, add JIT integration.


[ghstack-poisoned]
eellison pushed a commit that referenced this pull request Oct 7, 2020
Bind log1p and lgamma
b6e4d1c 
ghstack-source-id: c6df4fd
Pull Request resolved: #45791
Update on "[JIT] Bind log1p and lgamma"
9a3c6fb 
Most of the lowering for log1p and lgamma already existed, add JIT integration.

Differential Revision: [D24169536](https://our.internmc.facebook.com/intern/diff/D24169536)

[ghstack-poisoned]
eellison pushed a commit that referenced this pull request Oct 7, 2020
Bind log1p and lgamma
a2e44af 
ghstack-source-id: 17318ea
Pull Request resolved: #45791
@codecov
Copy link

codecov bot commented Oct 8, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (gh/eellison/115/base@cf02161). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                   @@
##             gh/eellison/115/base   #45791   +/-   ##
=======================================================
  Coverage                        ?   68.23%           
=======================================================
  Files                           ?      410           
  Lines                           ?    53266           
  Branches                        ?        0           
=======================================================
  Hits                            ?    36347           
  Misses                          ?    16919           
  Partials                        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf02161...9a3c6fb. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@eellison merged this pull request in 1197a38.

@facebook-github-bot facebook-github-bot deleted the gh/eellison/115/head branch October 12, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

@ZolotukhinM ZolotukhinM Awaiting requested review from ZolotukhinM

@bertmaher bertmaher Awaiting requested review from bertmaher

1 more reviewer

@Krovatkin Krovatkin Krovatkin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eellison @facebook-github-bot @Krovatkin