Skip to content

Conversation

ShijunK
Copy link
Contributor

@ShijunK ShijunK commented Oct 5, 2020

Summary: The method name in README is not consistent with actual implementation.

Differential Revision: D24114849

Summary: The method name in README is not consistent with actual implementation.

Differential Revision: D24114849

fbshipit-source-id: 5025a087dc0a234e92b6a146b8adb28a8214bec4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D24114849

@ShijunK ShijunK requested a review from mingzhe09088 October 5, 2020 17:44
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #45853 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #45853   +/-   ##
=======================================
  Coverage   68.32%   68.32%           
=======================================
  Files         410      410           
  Lines       52981    52981           
=======================================
  Hits        36200    36200           
  Misses      16781    16781           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 162717e...0c5d82c. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7d4f506.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants