[Distributed] Set smaller Store timeouts to make c10d tests run faster #46067
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our store tests, we expect there to be an exception when we call get on a recently-deleted key. Unforunately, the store waits for the timeout period for the key to be set before throwing, which causes the tests to idel wait for 5+ minutes. This PR decreases the timeouts before this set call so these tests run faster. Differential Revision: [D24208617](https://our.internmc.facebook.com/intern/diff/D24208617/) [ghstack-poisoned]
osalpekar
requested review from
mingzhe09088,
mrshenli,
pietern,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
facebook-github-bot
added
the
oncall: distributed
osalpekar
added a commit
that referenced
this pull request
Oct 8, 2020
In our store tests, we expect there to be an exception when we call get on a recently-deleted key. Unforunately, the store waits for the timeout period for the key to be set before throwing, which causes the tests to idel wait for 5+ minutes. This PR decreases the timeouts before this set call so these tests run faster. Differential Revision: [D24208617](https://our.internmc.facebook.com/intern/diff/D24208617/) ghstack-source-id: 113917315 Pull Request resolved: #46067
pritamdamania87
approved these changes
Oct 8, 2020
💊 CI failures summary and remediationsAs of commit ca7c66e (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
Codecov Report
@@ Coverage Diff @@
## gh/osalpekar/96/base #46067 +/- ##
=====================================================
Coverage 68.28% 68.28%
=====================================================
Files 410 410
Lines 53306 53306
=====================================================
Hits 36398 36398
Misses 16908 16908 Continue to review full report at Codecov.
|
|
This pull request has been merged in e33d455. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
In our store tests, we expect there to be an exception when we call
get on a recently-deleted key. Unforunately, the store waits for the timeout
period for the key to be set before throwing, which causes the tests to idel
wait for 5+ minutes. This PR decreases the timeouts before this set call so
these tests run faster.
Differential Revision: D24208617