make a way to disable callgrind #46116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D24227360 |
Codecov Report
@@ Coverage Diff @@
## master #46116 +/- ##
==========================================
- Coverage 68.26% 68.26% -0.01%
==========================================
Files 410 410
Lines 53533 53533
==========================================
- Hits 36543 36542 -1
- Misses 16990 16991 +1
Continue to review full report at Codecov.
|
malfet
requested changes
Oct 12, 2020
Summary: Pull Request resolved: pytorch#46116 Ideally I would just use one of the existing preprocessor flags such as `FBCODE_CAFFE2`, but this implies a whole bunch of other things elsewhere, so it is not really a solution for ovrsource. Test Plan: CI green, we are able to disable it internally with `-DNVALGRIND` Differential Revision: D24227360 fbshipit-source-id: 2145827bbb1fad22f4885b0c0a64352732c0de14
|
This pull request was exported from Phabricator. Differential Revision: D24227360 |
EscapeZero
force-pushed
the
export-D24227360
branch
from
a99d0a0 to
5f781b5
Compare
|
This pull request has been merged in b1d24dd. |
Miriup
pushed a commit
to Miriup/pytorch-cuda-10.2
that referenced
this pull request
Dec 9, 2024
Summary: Pull Request resolved: pytorch#46116 Ideally I would just use one of the existing preprocessor flags such as `FBCODE_CAFFE2`, but this implies a whole bunch of other things elsewhere, so it is not really a solution for ovrsource. Test Plan: CI green, we are able to disable it internally with `-DNVALGRIND` Reviewed By: malfet Differential Revision: D24227360 fbshipit-source-id: 24a3b393cf46d6a16acca0a9ec52610d4bb8704f (cherry picked from commit b1d24dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Ideally I would just use one of the existing preprocessor flags such as
FBCODE_CAFFE2, but this implies a whole bunch of other things elsewhere, so it is not really a solution for ovrsource.Test Plan: CI green, we are able to disable it internally with
-DNVALGRINDDifferential Revision: D24227360