Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Oct 17, 2020

As they are noops for the 90+ days but still take 10min from start to finish:
https://github.com/pytorch/pytorch/blob/58f14d3a28159bb958ad2dced18e29ad0aa616bb/.jenkins/pytorch/test.sh#L376-L374

@malfet malfet requested review from a team and ezyang October 17, 2020 03:06
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 17, 2020

💊 CI failures summary and remediations

As of commit a69fedc (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

@dr-ci
Copy link

dr-ci bot commented Oct 17, 2020

💊 CI failures summary and remediations

As of commit a69fedc (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_clang7_onnx_ort_test1 (1/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Oct 17 04:06:08 ERROR: No matching distribution found for ort-nightly==1.5.0.dev202009182
Oct 17 04:06:05 + pip install -q --user ninja 
Oct 17 04:06:06   WARNING: The script ninja is installed in '/var/lib/jenkins/.local/bin' which is not on PATH. 
Oct 17 04:06:06   Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location. 
Oct 17 04:06:06 + export PATH=/var/lib/jenkins/.local/bin:/opt/cache/bin:/opt/python//bin:/opt/conda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin 
Oct 17 04:06:06 + PATH=/var/lib/jenkins/.local/bin:/opt/cache/bin:/opt/python//bin:/opt/conda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin 
Oct 17 04:06:06 + [[ pytorch-linux-xenial-py3-clang7-onnx-ort_test1 == *py3* ]] 
Oct 17 04:06:06 + pip install --upgrade pip 
Oct 17 04:06:07 Requirement already up-to-date: pip in /opt/conda/lib/python3.6/site-packages (20.2.3) 
Oct 17 04:06:07 + pip install -q --user -i https://test.pypi.org/simple/ ort-nightly==1.5.0.dev202009182 
Oct 17 04:06:08 ERROR: Could not find a version that satisfies the requirement ort-nightly==1.5.0.dev202009182 (from versions: 1.5.2.dev202010091, 1.5.2.dev202010121, 1.5.2.dev202010141, 1.5.2.dev202010151, 1.5.2.dev202010161) 
Oct 17 04:06:08 ERROR: No matching distribution found for ort-nightly==1.5.0.dev202009182 

See CircleCI build pytorch_linux_xenial_py3_clang7_onnx_ort_test2 (2/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Oct 17 04:04:40 ERROR: No matching distribution found for ort-nightly==1.5.0.dev202009182
Oct 17 04:04:37 + pip install -q --user ninja 
Oct 17 04:04:38   WARNING: The script ninja is installed in '/var/lib/jenkins/.local/bin' which is not on PATH. 
Oct 17 04:04:38   Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location. 
Oct 17 04:04:38 + export PATH=/var/lib/jenkins/.local/bin:/opt/cache/bin:/opt/python//bin:/opt/conda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin 
Oct 17 04:04:38 + PATH=/var/lib/jenkins/.local/bin:/opt/cache/bin:/opt/python//bin:/opt/conda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin 
Oct 17 04:04:38 + [[ pytorch-linux-xenial-py3-clang7-onnx-ort_test2 == *py3* ]] 
Oct 17 04:04:38 + pip install --upgrade pip 
Oct 17 04:04:39 Requirement already up-to-date: pip in /opt/conda/lib/python3.6/site-packages (20.2.3) 
Oct 17 04:04:39 + pip install -q --user -i https://test.pypi.org/simple/ ort-nightly==1.5.0.dev202009182 
Oct 17 04:04:40 ERROR: Could not find a version that satisfies the requirement ort-nightly==1.5.0.dev202009182 (from versions: 1.5.2.dev202010091, 1.5.2.dev202010121, 1.5.2.dev202010141, 1.5.2.dev202010151, 1.5.2.dev202010161) 
Oct 17 04:04:40 ERROR: No matching distribution found for ort-nightly==1.5.0.dev202009182 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@dr-ci
Copy link

dr-ci bot commented Oct 17, 2020

💊 CI failures summary and remediations

As of commit a69fedc (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR---

2 failures not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_xenial_py3_clang7_onnx_ort_test2 Run tests 🔁 rerun
CircleCI pytorch_linux_xenial_py3_clang7_onnx_ort_test1 Run tests 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #46508 into master will increase coverage by 0.05%.
The diff coverage is 71.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #46508      +/-   ##
==========================================
+ Coverage   68.33%   68.39%   +0.05%     
==========================================
  Files         410      411       +1     
  Lines       53805    53963     +158     
==========================================
+ Hits        36770    36907     +137     
- Misses      17035    17056      +21     
Impacted Files Coverage Δ
...ch/testing/_internal/common_methods_invocations.py 91.45% <ø> (ø)
...orch/testing/_internal/distributed/rpc/rpc_test.py 26.28% <0.00%> (-0.02%) ⬇️
...enchmark/utils/valgrind_wrapper/compat_bindings.py 0.00% <0.00%> (ø)
...enchmark/utils/valgrind_wrapper/timer_interface.py 49.09% <59.06%> (+23.31%) ⬆️
torch/utils/benchmark/utils/timer.py 85.88% <83.33%> (+7.05%) ⬆️
torch/fx/proxy.py 93.75% <89.28%> (+1.08%) ⬆️
torch/utils/benchmark/utils/common.py 98.63% <97.43%> (+2.23%) ⬆️
torch/fx/symbolic_trace.py 95.87% <100.00%> (+0.04%) ⬆️
torch/jit/_recursive.py 95.14% <100.00%> (+0.02%) ⬆️
torch/quantization/_numeric_suite.py 95.65% <100.00%> (+0.02%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f61fa6...a69fedc. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in 351670f.

@malfet malfet deleted the malfet/delete-libtorch-test-jobs branch October 19, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants