Skip to content

Conversation

@guilhermeleobas
Copy link
Collaborator

Fixes #46735

@guilhermeleobas guilhermeleobas added the module: typing Related to mypy type annotations label Oct 22, 2020
@guilhermeleobas guilhermeleobas self-assigned this Oct 22, 2020
@dr-ci
Copy link

dr-ci bot commented Oct 22, 2020

💊 CI failures summary and remediations

As of commit 6a95d25 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

codecov.io: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 15 times.

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #46736 into master will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master   #46736   +/-   ##
=======================================
  Coverage   68.96%   68.96%           
=======================================
  Files         434      434           
  Lines       55986    55987    +1     
=======================================
+ Hits        38612    38613    +1     
  Misses      17374    17374           

@guilhermeleobas guilhermeleobas marked this pull request as ready for review October 26, 2020 18:35
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mrshenli merged this pull request in 717e6d8.

@guilhermeleobas guilhermeleobas deleted the comm branch October 27, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: typing Related to mypy type annotations open source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable torch.nn.parallel.comm typechecks during CI

4 participants