Perform explicit cast #46771
Closed
Perform explicit cast #46771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `std::ceil` returns a `float` which is cast to `size_t` by the `max` operation. We convert to `int64_t` to suppress the warning while matching the type of `newDims[0]`. Since the types match, we don't need an explicit template type for `max`. This allows `max` to take `int64_t` as its values, matching the type of `newCapacity`. Test Plan: Standard pre-commit test rig. Reviewed By: malfet Differential Revision: D24481684 fbshipit-source-id: f8708ec1044dbc14ea091c9917b087cb79e97183
|
This pull request was exported from Phabricator. Differential Revision: D24481684 |
💊 CI failures summary and remediationsAs of commit 44ab386 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
Codecov Report
@@ Coverage Diff @@
## master #46771 +/- ##
==========================================
- Coverage 68.98% 68.98% -0.01%
==========================================
Files 433 433
Lines 55919 55919
==========================================
- Hits 38577 38576 -1
- Misses 17342 17343 +1 |
|
This pull request has been merged in fa8cd06. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
std::ceilreturns afloatwhich is cast tosize_tby themaxoperation.We convert to
int64_tto suppress the warning while matching the type ofnewDims[0].Since the types match, we don't need an explicit template type for
max. This allowsmaxto takeint64_tas its values, matching the type ofnewCapacity.Test Plan: Standard pre-commit test rig.
Reviewed By: malfet
Differential Revision: D24481684