-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[ONNX] Fix eye export #47016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX] Fix eye export #47016
Conversation
Codecov Report
@@ Coverage Diff @@
## master #47016 +/- ##
==========================================
- Coverage 68.94% 68.93% -0.01%
==========================================
Files 434 434
Lines 56188 56197 +9
==========================================
+ Hits 38740 38741 +1
- Misses 17448 17456 +8 |
💊 CI failures summary and remediationsAs of commit 8cb630f (more details on the Dr. CI page):
codecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT. Thanks!
|
Hi @BowenBao! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but we do not have a signature on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Previously did not considered the case were optional
mis not provided intorch.eye(n, m).