Skip to content

Conversation

@BowenBao
Copy link
Collaborator

Previously did not considered the case were optional m is not provided in torch.eye(n, m).

@VitalyFedyunin VitalyFedyunin added the module: onnx Related to torch.onnx label Oct 28, 2020
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #47016 into master will decrease coverage by 0.00%.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##           master   #47016      +/-   ##
==========================================
- Coverage   68.94%   68.93%   -0.01%     
==========================================
  Files         434      434              
  Lines       56188    56197       +9     
==========================================
+ Hits        38740    38741       +1     
- Misses      17448    17456       +8     

@dr-ci
Copy link

dr-ci bot commented Oct 29, 2020

💊 CI failures summary and remediations

As of commit 8cb630f (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

codecov.io: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

@albanD albanD requested a review from houseroad October 29, 2020 14:26
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 29, 2020
Copy link
Contributor

@neginraoof neginraoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Thanks!

@facebook-github-bot
Copy link
Contributor

Hi @BowenBao!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@bzinodev merged this pull request in 0fb1356.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged module: onnx Related to torch.onnx open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants