[FX] Fix handling of attributes #47030
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesr66a
reviewed
Oct 28, 2020
💊 CI failures summary and remediationsAs of commit 6cc39cb (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 29 times. |
Chillee
changed the title
Codecov Report
@@ Coverage Diff @@
## master #47030 +/- ##
=======================================
Coverage 68.95% 68.95%
=======================================
Files 434 434
Lines 56207 56220 +13
=======================================
+ Hits 38760 38769 +9
- Misses 17447 17451 +4 |
jamesr66a
reviewed
Oct 29, 2020
test/test_fx.py
Outdated
| return self.a.b, self.a.b.t(), self.a.b.view(12) | ||
|
|
||
| traced = torch.fx.symbolic_trace(Foo()) | ||
| assert(all('constant' not in node.name for node in traced.graph.nodes)) |
There was a problem hiding this comment.
Oh also don't match on name, that isn't stable. You can do this same check on node.target
There was a problem hiding this comment.
@Chillee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably works :)
Fixes #46872