For torch::jit::module's attr method to moble::module #47059
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
oncall: jit
|
This pull request was exported from Phabricator. Differential Revision: D24604950 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D24604950 |
kimishpatel
force-pushed
the
export-D24604950
branch
from
0fe53fd to
c18c76d
Compare
|
Would be nice to have get_attr for mobile module. Could you add a unit test on it? I think we could use model similar to https://github.com/pytorch/pytorch/blob/master/test/cpp/jit/test_lite_interpreter.cpp#L51 |
Summary: Pull Request resolved: pytorch#47059 This diff adds attr getter to mobile::module similar to torchscript module at https://github.com/pytorch/pytorch/blob/master/torch/csrc/jit/api/object.h#L75-L83. Test Plan: LiteInterpreterTest::CheckAttrAccess Reviewed By: xta0 Differential Revision: D24604950 fbshipit-source-id: 829e9a9451b6bd12a291e1731feac14271196b37
|
This pull request was exported from Phabricator. Differential Revision: D24604950 |
kimishpatel
force-pushed
the
export-D24604950
branch
from
c18c76d to
dd49db6
Compare
|
This pull request has been merged in 82b74bd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff adds attr getter to mobile::module similar to torchscript module at https://github.com/pytorch/pytorch/blob/master/torch/csrc/jit/api/object.h#L75-L83.
Test Plan: CI
Differential Revision: D24604950