Skip to content

Conversation

@dreiss
Copy link
Contributor

@dreiss dreiss commented Nov 6, 2020

Stack from ghstack:

Summary:
While we're unlikely to see this in practice, it comes up in unit tests.
This type annotation is necessary for torch.jit.script to figure out
the type of the list if it is empty.

Test Plan:
Unit tests in a later diff.

Differential Revision: D25317937

Summary:
While we're unlikely to see this in practice, it comes up in unit tests.
This type annotation is necessary for `torch.jit.script` to figure out
the type of the list if it is empty.

Test Plan:
Unit tests in a later diff.

[ghstack-poisoned]
@dr-ci
Copy link

dr-ci bot commented Nov 6, 2020

💊 CI failures summary and remediations

As of commit 0333c68 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Summary:
While we're unlikely to see this in practice, it comes up in unit tests.
This type annotation is necessary for `torch.jit.script` to figure out
the type of the list if it is empty.

Test Plan:
Unit tests in a later diff.

[ghstack-poisoned]
Summary:
While we're unlikely to see this in practice, it comes up in unit tests.
This type annotation is necessary for `torch.jit.script` to figure out
the type of the list if it is empty.

Test Plan:
Unit tests in a later diff.

Differential Revision: [D25317937](https://our.internmc.facebook.com/intern/diff/D25317937)

[ghstack-poisoned]
Summary:
While we're unlikely to see this in practice, it comes up in unit tests.
This type annotation is necessary for `torch.jit.script` to figure out
the type of the list if it is empty.

Test Plan:
Unit tests in a later diff.

Differential Revision: [D25317937](https://our.internmc.facebook.com/intern/diff/D25317937)

[ghstack-poisoned]
dreiss added 4 commits March 31, 2021 20:54
Summary:
While we're unlikely to see this in practice, it comes up in unit tests.
This type annotation is necessary for `torch.jit.script` to figure out
the type of the list if it is empty.

Test Plan:
Unit tests in a later diff.

Differential Revision: [D25317937](https://our.internmc.facebook.com/intern/diff/D25317937)

[ghstack-poisoned]
Summary:
While we're unlikely to see this in practice, it comes up in unit tests.
This type annotation is necessary for `torch.jit.script` to figure out
the type of the list if it is empty.

Test Plan:
Unit tests in a later diff.

Differential Revision: [D25317937](https://our.internmc.facebook.com/intern/diff/D25317937)

[ghstack-poisoned]
Summary:
While we're unlikely to see this in practice, it comes up in unit tests.
This type annotation is necessary for `torch.jit.script` to figure out
the type of the list if it is empty.

Test Plan:
Unit tests in a later diff.

Differential Revision: [D25317937](https://our.internmc.facebook.com/intern/diff/D25317937)

[ghstack-poisoned]
Summary:
While we're unlikely to see this in practice, it comes up in unit tests.
This type annotation is necessary for `torch.jit.script` to figure out
the type of the list if it is empty.

Test Plan:
Unit tests in a later diff.

Differential Revision: [D25317937](https://our.internmc.facebook.com/intern/diff/D25317937)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@dreiss merged this pull request in 1be909f.

@facebook-github-bot facebook-github-bot deleted the gh/dreiss/81/head branch April 10, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants