Pass in smaller timeout into init_process_group for distributed_test #47896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per title Differential Revision: [D24943323](https://our.internmc.facebook.com/intern/diff/D24943323/) [ghstack-poisoned]
rohan-varma
requested review from
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
facebook-github-bot
added
cla signed
oncall: distributed
💊 CI failures summary and remediationsAs of commit df13f4c (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 11 times. |
…buted_test" Per title Differential Revision: [D24943323](https://our.internmc.facebook.com/intern/diff/D24943323/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 13, 2020
Pull Request resolved: #47896 Per title ghstack-source-id: 116607077 Differential Revision: [D24943323](https://our.internmc.facebook.com/intern/diff/D24943323/)
osalpekar
approved these changes
Nov 14, 2020
…buted_test" Closes #47892. Since we have a 100s timeout on the entire test, we should have a smaller timeout than the default 30 min for the process group used for the test. This diff sets the timeout to 60s. For example, this is useful when running tests with NCCL_BLOCKING_WAIT so that we get the op timed out error instead of the test itself timing out. Differential Revision: [D24943323](https://our.internmc.facebook.com/intern/diff/D24943323/) [ghstack-poisoned]
…buted_test" Closes #47892. Since we have a 100s timeout on the entire test, we should have a smaller timeout than the default 30 min for the process group used for the test. This diff sets the timeout to 60s. For example, this is useful when running tests with NCCL_BLOCKING_WAIT so that we get the op timed out error instead of the test itself timing out. Differential Revision: [D24943323](https://our.internmc.facebook.com/intern/diff/D24943323/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 14, 2020
Pull Request resolved: #47896 Per title ghstack-source-id: 116710141 Differential Revision: [D24943323](https://our.internmc.facebook.com/intern/diff/D24943323/)
|
This pull request has been merged in f824854. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Closes #47892. Since we have a 100s timeout on the entire test, we should have a smaller timeout than the default 30 min for the process group used for the test.
This diff sets the timeout to 60s. For example, this is useful when running tests with NCCL_BLOCKING_WAIT so that we get the op timed out error instead of the test itself timing out.
Differential Revision: D24943323