Document that remainder does not support complex inputs
#48024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtamohler
force-pushed
the
remainder-docs-no-complex-support-34266
branch
from
508f67d to
8a9a01c
Compare
💊 CI failures summary and remediationsAs of commit 051a18b (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 1 failure confirmed as flaky and can be ignored:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 5 times. |
mruberry
reviewed
Nov 17, 2020
mruberry
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Thanks @kurtamohler, just one suggestion to kill the last sentence.
kurtamohler
force-pushed
the
remainder-docs-no-complex-support-34266
branch
from
8a9a01c to
051a18b
Compare
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #48024 +/- ##
=======================================
Coverage 81.31% 81.31%
=======================================
Files 1839 1839
Lines 198692 198692
=======================================
+ Hits 161558 161563 +5
+ Misses 37134 37129 -5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34266