Fix collect_env.py with older version of PyTorch

[skyline75489]

Inspired by #47993, this fixes the import error in collect_env.py with older version of PyTorch when torch.version does not have hip property.

The way to reproduce the crash is simple:

1. Install torch==1.2.0.
2. Run the collect_env.py

[dr-ci]

💊 CI failures summary and remediations

As of commit fc1ab5b (more details on the Dr. CI page):

---

• 1/1 failures possibly* introduced in this PR
  • 1/1 non-CircleCI failure(s)

---

codecov.io: 1 failed

• Failed: codecov/patch

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 5 times.

[codecov]

Codecov Report

Merging #48076 (fc1ab5b) into master (af37f8f) will decrease coverage by 0.15%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #48076      +/-   ##
==========================================
- Coverage   81.31%   81.16%   -0.16%     
==========================================
  Files        1839     1839              
  Lines      198670   198670              
==========================================
- Hits       161544   161245     -299     
- Misses      37126    37425     +299     

[facebook-github-bot]

@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[samestep]

lgtm 👍 could you add a test plan to this PR though? I see a bunch of discussion in the linked issue, but it would be nice if you could summarize here the exact steps one would need to take to reproduce the past and current behavior.

[skyline75489]

@samstep Hi. I updated the PR description about how to reproduce the crash. It's dead simple. I assume torch<=1.2.0 would all suffer from this. With this fix, it will not crash any more.

However I don't know what exactly a "test plan" is. Is it something I should add in the PR description, or is it something more like a unit test?

[samestep]

@skyline75489 Awesome, thanks :) and no you don't need to add a unit test or anything, that's all I was looking for. Now I just need another FB employee to approve the diff that I imported so I can land your change 👍

[facebook-github-bot]

@samestep merged this pull request in 9b19880.