Skip to content

Delete "-b" flag from pip install command #48722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Delete "-b" flag from pip install command #48722

wants to merge 1 commit into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Dec 2, 2020

"--build

" flag has been deprecated for a while and finally removed in pip-20.3

Before this PR is applied, every change to docker images would result in ONNX failures

@malfet
Delete "-b" flag from pip install command
d5e46f4 
"--build <dir>" flag has been deprecated for a while and finally removed in pip-20.3
@malfet malfet requested review from a team and jeffdaily December 2, 2020 16:45
facebook-github-bot
facebook-github-bot reviewed Dec 2, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jeffdaily
Copy link
Collaborator

jeffdaily commented Dec 2, 2020 •
edited
Loading

Aha! Now that explains why #48118 failed. Good.

@jeffdaily jeffdaily mentioned this pull request Dec 2, 2020
Closed
@dr-ci
Copy link

dr-ci bot commented Dec 2, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit d5e46f4 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@malfet malfet deleted the malfet/delete-pip-b-flag branch December 2, 2020 18:02
@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in dc367e7.

facebook-github-bot pushed a commit that referenced this pull request Dec 2, 2020
@jeffdaily @facebook-github-bot
[reland] [ROCm] remove versions less than 3.8 (#48723)
bdb68d9 
Summary:
First attempt to land #48118 failed due to the problem fixed by #48722.

Pull Request resolved: #48723

Reviewed By: bdhirsh

Differential Revision: D25274287

Pulled By: malfet

fbshipit-source-id: 3ff0be3b522012c647448e5173b3ae38446d4120
malfet added a commit that referenced this pull request Dec 2, 2020
@malfet
Remove "-b" option from pip install command
0aeb1a3 
It has been deprecated for a while and was finally removed in 20.3
Followup after #48722
@malfet malfet mentioned this pull request Dec 2, 2020
Closed
facebook-github-bot pushed a commit that referenced this pull request Dec 2, 2020
@malfet @facebook-github-bot
Remove "-b" option from pip install command (#48742)
a49e2c5 
Summary:
It has been deprecated for a while and was finally removed in 20.3
Followup after #48722
Fixes ONNX build failures after docker image update

Pull Request resolved: #48742

Reviewed By: walterddr

Differential Revision: D25282017

Pulled By: malfet

fbshipit-source-id: 1dfa4eb57398f979107ca1544aafbc6d7b5e68a4
jeffdaily pushed a commit to ROCm/pytorch that referenced this pull request Dec 2, 2020
@malfet @jeffdaily
Remove "-b" option from pip install command (pytorch#48742)
e01891c 
Summary:
It has been deprecated for a while and was finally removed in 20.3
Followup after pytorch#48722
Fixes ONNX build failures after docker image update

Pull Request resolved: pytorch#48742

Reviewed By: walterddr

Differential Revision: D25282017

Pulled By: malfet

fbshipit-source-id: 1dfa4eb57398f979107ca1544aafbc6d7b5e68a4
jeffdaily pushed a commit to ROCm/pytorch that referenced this pull request Dec 2, 2020
@malfet @jeffdaily
Delete "-b" flag from pip install command (pytorch#48722)
92d5153 
Summary:
"--build <dir>" flag has been deprecated for a while and finally removed in pip-20.3

Before this PR is applied, every change to docker images would result in ONNX failures

Pull Request resolved: pytorch#48722

Reviewed By: janeyx99

Differential Revision: D25274020

Pulled By: malfet

fbshipit-source-id: 9e0f9daba58ceeec5474d649d1b22bfeca91d7bc
jeffdaily pushed a commit to ROCm/pytorch that referenced this pull request Dec 2, 2020
@malfet @jeffdaily
Delete "-b" flag from pip install command (pytorch#48722)
56fa66c 
Summary:
"--build <dir>" flag has been deprecated for a while and finally removed in pip-20.3

Before this PR is applied, every change to docker images would result in ONNX failures

Pull Request resolved: pytorch#48722

Reviewed By: janeyx99

Differential Revision: D25274020

Pulled By: malfet

fbshipit-source-id: 9e0f9daba58ceeec5474d649d1b22bfeca91d7bc
jeffdaily pushed a commit to ROCm/pytorch that referenced this pull request Dec 2, 2020
@malfet @jeffdaily
Remove "-b" option from pip install command (pytorch#48742)
f132130 
Summary:
It has been deprecated for a while and was finally removed in 20.3
Followup after pytorch#48722
Fixes ONNX build failures after docker image update

Pull Request resolved: pytorch#48742

Reviewed By: walterddr

Differential Revision: D25282017

Pulled By: malfet

fbshipit-source-id: 1dfa4eb57398f979107ca1544aafbc6d7b5e68a4
shaibagon pushed a commit to shaibagon/pytorch that referenced this pull request Dec 3, 2020
@malfet @shaibagon
Delete "-b" flag from pip install command (pytorch#48722)
b8bc4d9 
Summary:
"--build <dir>" flag has been deprecated for a while and finally removed in pip-20.3

Before this PR is applied, every change to docker images would result in ONNX failures

Pull Request resolved: pytorch#48722

Reviewed By: janeyx99

Differential Revision: D25274020

Pulled By: malfet

fbshipit-source-id: 9e0f9daba58ceeec5474d649d1b22bfeca91d7bc
shaibagon pushed a commit to shaibagon/pytorch that referenced this pull request Dec 3, 2020
@jeffdaily @shaibagon
[reland] [ROCm] remove versions less than 3.8 (pytorch#48723)
d5caa3f 
Summary:
First attempt to land pytorch#48118 failed due to the problem fixed by pytorch#48722.

Pull Request resolved: pytorch#48723

Reviewed By: bdhirsh

Differential Revision: D25274287

Pulled By: malfet

fbshipit-source-id: 3ff0be3b522012c647448e5173b3ae38446d4120
shaibagon pushed a commit to shaibagon/pytorch that referenced this pull request Dec 3, 2020
@malfet @shaibagon
Remove "-b" option from pip install command (pytorch#48742)
be86b20 
Summary:
It has been deprecated for a while and was finally removed in 20.3
Followup after pytorch#48722
Fixes ONNX build failures after docker image update

Pull Request resolved: pytorch#48742

Reviewed By: walterddr

Differential Revision: D25282017

Pulled By: malfet

fbshipit-source-id: 1dfa4eb57398f979107ca1544aafbc6d7b5e68a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@janeyx99 janeyx99 janeyx99 approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @jeffdaily @facebook-github-bot @janeyx99