[PyTorch] Save some space in ProcessedNode #48861
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`std::function` already has an empty state; no need to wrap it in `c10::Optional`. Differential Revision: [D25296912](https://our.internmc.facebook.com/intern/diff/D25296912/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25296912/)! [ghstack-poisoned]
facebook-github-bot
added
cla signed
oncall: jit
swolchok
added a commit
that referenced
this pull request
Dec 4, 2020
`std::function` already has an empty state; no need to wrap it in `c10::Optional`. Differential Revision: [D25296912](https://our.internmc.facebook.com/intern/diff/D25296912/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25296912/)! ghstack-source-id: 117891382 Pull Request resolved: #48861
💊 CI failures summary and remediationsAs of commit 70cc145 (more details on the Dr. CI page):
codecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. |
|
This pull request has been merged in 0f9823d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
std::functionalready has an empty state; no need to wrapit in
c10::Optional.Differential Revision: D25296912
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!