[JIT] Allow del statements with multiple targets #48876
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** This commit adds support for `del` statements with multiple targets. Targets are deleted left-to-right just like Python. **Test Plan** This commit updates the `TestBuiltins.test_del_multiple_operands` unit test to actually test that multiple deletion works instead of asserting that an error is thrown. [ghstack-poisoned]
SplitInfinity
pushed a commit
that referenced
this pull request
Dec 5, 2020
**Summary** This commit adds support for `del` statements with multiple targets. Targets are deleted left-to-right just like Python. **Test Plan** This commit updates the `TestBuiltins.test_del_multiple_operands` unit test to actually test that multiple deletion works instead of asserting that an error is thrown. ghstack-source-id: 95de87f Pull Request resolved: #48876
facebook-github-bot
added
cla signed
oncall: jit
💊 CI failures summary and remediationsAs of commit 28eaa17 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 5 ongoing upstream failures:These were probably caused by upstream breakages that are not fixed yet:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 13 times. |
gmagogsfm
approved these changes
Dec 5, 2020
|
|
||
| py_out = del_list_multiple_operands([0, 1, 2]) | ||
| jit_out = torch.jit.script(del_list_multiple_operands)([0, 1, 2]) | ||
| self.assertEquals(py_out, jit_out) |
There was a problem hiding this comment.
You can't - list inputs are mutable. A list input will be mutated by the script function and then reused by the eager mode function.
**Summary** This commit adds support for `del` statements with multiple targets. Targets are deleted left-to-right just like Python. **Test Plan** This commit updates the `TestBuiltins.test_del_multiple_operands` unit test to actually test that multiple deletion works instead of asserting that an error is thrown. **Fixes** This commit fixes #48635. [ghstack-poisoned]
SplitInfinity
pushed a commit
that referenced
this pull request
Dec 7, 2020
**Summary** This commit adds support for `del` statements with multiple targets. Targets are deleted left-to-right just like Python. **Test Plan** This commit updates the `TestBuiltins.test_del_multiple_operands` unit test to actually test that multiple deletion works instead of asserting that an error is thrown. ghstack-source-id: 4ec341a Pull Request resolved: #48876
|
@SplitInfinity merged this pull request in 3f9ff48. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
This commit adds support for
delstatements with multiple targets.Targets are deleted left-to-right just like Python.
Test Plan
This commit updates the
TestBuiltins.test_del_multiple_operandsunittest to actually test that multiple deletion works instead of asserting
that an error is thrown.
Fixes
This commit fixes #48635.
Differential Revision: D25386285