Skip to content

Conversation

@jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Dec 7, 2020

Stack from ghstack:

Summary:
Add numerical test for fx graph mode for resnet base, comparing with eager mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D25375342

Summary:
Add numerical test for fx graph mode for resnet base, comparing with eager mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Dec 7, 2020
Summary:
Add numerical test for fx graph mode for resnet base, comparing with eager mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 798c8c1
Pull Request resolved: #48939
@dr-ci
Copy link

dr-ci bot commented Dec 7, 2020

💊 CI failures summary and remediations

As of commit da94b7f (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



🚧 4 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 22 times.

Summary:
Add numerical test for fx graph mode for resnet base, comparing with eager mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25375342](https://our.internmc.facebook.com/intern/diff/D25375342)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Dec 7, 2020
Summary:
Add numerical test for fx graph mode for resnet base, comparing with eager mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 12b4ed9
Pull Request resolved: #48939
Copy link
Contributor

@supriyar supriyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Summary:
Add numerical test for fx graph mode for resnet base, comparing with eager mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25375342](https://our.internmc.facebook.com/intern/diff/D25375342)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Dec 8, 2020
Summary:
Add numerical test for fx graph mode for resnet base, comparing with eager mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 652575b
Pull Request resolved: #48939
Summary:
Add numerical test for fx graph mode for resnet base, comparing with eager mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25375342](https://our.internmc.facebook.com/intern/diff/D25375342)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Dec 9, 2020
Summary:
Add numerical test for fx graph mode for resnet base, comparing with eager mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: cdca66e
Pull Request resolved: #48939
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 2d9585a.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/516/head branch December 12, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants