[quant][fix] Support quantization of ops where input is quantizable #49027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: For cat followed by linear since the output of cat is not quanitzed, we didnt quantize the linear This checks the uses of the cat op to insert observers Test Plan: python test/test_quantization.py TestQuantizeJitOps.test_cat_linear Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
facebook-github-bot
added
cla signed
oncall: jit
supriyar
added a commit
that referenced
this pull request
Dec 8, 2020
Summary: For cat followed by linear since the output of cat is not quanitzed, we didnt quantize the linear This checks the uses of the cat op to insert observers Test Plan: python test/test_quantization.py TestQuantizeJitOps.test_cat_linear Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 96c9d4a Pull Request resolved: #49027
Codecov Report
@@ Coverage Diff @@
## gh/supriyar/209/base #49027 +/- ##
=====================================================
Coverage 80.77% 80.78%
=====================================================
Files 1866 1866
Lines 201408 201412 +4
=====================================================
+ Hits 162692 162705 +13
+ Misses 38716 38707 -9 |
|
This pull request has been merged in 4434c07. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
For cat followed by linear since the output of cat is not quanitzed, we didnt quantize the linear
This checks the uses of the cat op to insert observers
Test Plan:
python test/test_quantization.py TestQuantizeJitOps.test_cat_linear
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D25403412