[JIT] Use is_buffer in BufferPolicy::valid
#49053
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** `BufferPolicy::valid` uses `!typ->is_parameter(i)` to check if an attribute is a buffer or not; it should use `type->is_buffer(i)` instead. **Test Plan** It is difficult to write an additional test that would have failed before this commit because the two booleans `is_parameter` and `is_buffer` are never set to `true` at the same time. **Fixes** This commit fixes #48746. [ghstack-poisoned]
facebook-github-bot
added
cla signed
oncall: jit
SplitInfinity
pushed a commit
that referenced
this pull request
Dec 8, 2020
**Summary** `BufferPolicy::valid` uses `!typ->is_parameter(i)` to check if an attribute is a buffer or not; it should use `type->is_buffer(i)` instead. **Test Plan** It is difficult to write an additional test that would have failed before this commit because the two booleans `is_parameter` and `is_buffer` are never set to `true` at the same time. **Fixes** This commit fixes #48746. ghstack-source-id: e249dd1 Pull Request resolved: #49053
Codecov Report
@@ Coverage Diff @@
## gh/splitinfinity/80/base #49053 +/- ##
=========================================================
Coverage 80.74% 80.74%
=========================================================
Files 1870 1870
Lines 201724 201724
=========================================================
+ Hits 162877 162886 +9
+ Misses 38847 38838 -9 |
ansley
approved these changes
Dec 9, 2020
|
@SplitInfinity merged this pull request in a480ca5. |
|
This pull request has been reverted by b5b8fe9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
is_bufferinBufferPolicy::valid#49053 [JIT] Useis_bufferinBufferPolicy::validSummary
BufferPolicy::validuses!typ->is_parameter(i)to check if anattribute is a buffer or not; it should use
type->is_buffer(i)instead.Test Plan
It is difficult to write an additional test that would have failed before this
commit because the two booleans
is_parameterandis_bufferare never setto
trueat the same time.Fixes
This commit fixes #48746.
Differential Revision: D25434956