Skip to content

Conversation

bdhirsh
Copy link
Contributor

@bdhirsh bdhirsh commented Dec 8, 2020

This is another byte-for-byte compatibility hack. I'm now sorting pyi signature overloads (previously the codegen did not).

Mostly put this in a separate PR just to more easily reason about the diff in the codegen output.

Stack from ghstack:

Differential Revision: D25410846

@dr-ci
Copy link

dr-ci bot commented Dec 9, 2020

💊 CI failures summary and remediations

As of commit 05e3e0e (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 22 times.

…sorting overloads)"

This is another byte-for-byte compatibility hack. I'm now sorting pyi signature overloads (previously the codegen did not).

Mostly put this in a separate PR just to more easily reason about the diff in the codegen output.


Differential Revision: [D25410846](https://our.internmc.facebook.com/intern/diff/D25410846)

[ghstack-poisoned]
…sorting overloads)"

This is another byte-for-byte compatibility hack. I'm now sorting pyi signature overloads (previously the codegen did not).

Mostly put this in a separate PR just to more easily reason about the diff in the codegen output.


Differential Revision: [D25410846](https://our.internmc.facebook.com/intern/diff/D25410846)

[ghstack-poisoned]
…sorting overloads)"

This is another byte-for-byte compatibility hack. I'm now sorting pyi signature overloads (previously the codegen did not).

Mostly put this in a separate PR just to more easily reason about the diff in the codegen output.


Differential Revision: [D25410846](https://our.internmc.facebook.com/intern/diff/D25410846)

[ghstack-poisoned]
@bdhirsh bdhirsh requested review from ezyang and ljk53 December 9, 2020 18:06
…sorting overloads)"

This is another byte-for-byte compatibility hack. I'm now sorting pyi signature overloads (previously the codegen did not).

Mostly put this in a separate PR just to more easily reason about the diff in the codegen output.


Differential Revision: [D25410846](https://our.internmc.facebook.com/intern/diff/D25410846)

[ghstack-poisoned]
…sorting overloads)"

This is another byte-for-byte compatibility hack. I'm now sorting pyi signature overloads (previously the codegen did not).

Mostly put this in a separate PR just to more easily reason about the diff in the codegen output.


Differential Revision: [D25410846](https://our.internmc.facebook.com/intern/diff/D25410846)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@bdhirsh merged this pull request in 33a9b14.

@facebook-github-bot facebook-github-bot deleted the gh/bdhirsh/61/head branch December 15, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants