-
Notifications
You must be signed in to change notification settings - Fork 25.6k
pyi codegen - removing byte-for-byte-compatibility hacks (sorting overloads) #49056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rloads) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 05e3e0e (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
…sorting overloads)" This is another byte-for-byte compatibility hack. I'm now sorting pyi signature overloads (previously the codegen did not). Mostly put this in a separate PR just to more easily reason about the diff in the codegen output. Differential Revision: [D25410846](https://our.internmc.facebook.com/intern/diff/D25410846) [ghstack-poisoned]
…sorting overloads)" This is another byte-for-byte compatibility hack. I'm now sorting pyi signature overloads (previously the codegen did not). Mostly put this in a separate PR just to more easily reason about the diff in the codegen output. Differential Revision: [D25410846](https://our.internmc.facebook.com/intern/diff/D25410846) [ghstack-poisoned]
…sorting overloads)" This is another byte-for-byte compatibility hack. I'm now sorting pyi signature overloads (previously the codegen did not). Mostly put this in a separate PR just to more easily reason about the diff in the codegen output. Differential Revision: [D25410846](https://our.internmc.facebook.com/intern/diff/D25410846) [ghstack-poisoned]
…sorting overloads)" This is another byte-for-byte compatibility hack. I'm now sorting pyi signature overloads (previously the codegen did not). Mostly put this in a separate PR just to more easily reason about the diff in the codegen output. Differential Revision: [D25410846](https://our.internmc.facebook.com/intern/diff/D25410846) [ghstack-poisoned]
…sorting overloads)" This is another byte-for-byte compatibility hack. I'm now sorting pyi signature overloads (previously the codegen did not). Mostly put this in a separate PR just to more easily reason about the diff in the codegen output. Differential Revision: [D25410846](https://our.internmc.facebook.com/intern/diff/D25410846) [ghstack-poisoned]
This is another byte-for-byte compatibility hack. I'm now sorting pyi signature overloads (previously the codegen did not).
Mostly put this in a separate PR just to more easily reason about the diff in the codegen output.
Stack from ghstack:
Differential Revision: D25410846