[te] Add gflag for fast intrinsic expansion #49060
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TE contains a fast tanh/sigmoid implementation that may be slightly less precise than the eager implementation (I measured 1 ulp in some test cases). We disabled it by default using an #ifdef but that may be too conservative. Adding a gflag allows more testing without recompilation. Differential Revision: [D25406421](https://our.internmc.facebook.com/intern/diff/D25406421/) [ghstack-poisoned]
facebook-github-bot
added
cla signed
oncall: jit
This was referenced Dec 8, 2020
Codecov Report
@@ Coverage Diff @@
## gh/bertmaher/43/base #49060 +/- ##
========================================================
- Coverage 80.76% 80.76% -0.01%
========================================================
Files 1867 1867
Lines 201589 201593 +4
========================================================
- Hits 162822 162820 -2
- Misses 38767 38773 +6 |
💊 CI failures summary and remediationsAs of commit 1d24ee8 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
codecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
|
This pull request has been merged in b98e62f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
TE contains a fast tanh/sigmoid implementation that may be slightly less precise than the eager implementation (I measured 1 ulp in some test cases). We disabled it by default using an #ifdef but that may be too conservative. Adding a gflag allows more testing without recompilation.
Differential Revision: D25406421